From owner-freebsd-current@FreeBSD.ORG Fri Dec 9 12:54:11 2005 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8F9D216A41F for ; Fri, 9 Dec 2005 12:54:11 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.FreeBSD.org (Postfix) with ESMTP id 67C7043D5A for ; Fri, 9 Dec 2005 12:53:56 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.5b3) with ESMTP id 3446351 for multiple; Fri, 09 Dec 2005 07:56:03 -0500 Received: from zion.baldwin.cx (zion.baldwin.cx [192.168.0.7]) (authenticated bits=0) by server.baldwin.cx (8.13.1/8.13.1) with ESMTP id jB9Crp0l079193; Fri, 9 Dec 2005 07:53:52 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: freebsd-current@freebsd.org Date: Fri, 9 Dec 2005 07:53:48 -0500 User-Agent: KMail/1.8.3 References: <20051206093020.691e1483.ai@bmc.brk.ru> <200512080951.52387.jhb@freebsd.org> <20051209143634.09bc2d90.ai@bmc.brk.ru> In-Reply-To: <20051209143634.09bc2d90.ai@bmc.brk.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200512090753.49989.jhb@freebsd.org> X-Spam-Status: No, score=-2.8 required=4.2 tests=ALL_TRUSTED autolearn=failed version=3.0.2 X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on server.baldwin.cx X-Server: High Performance Mail Server - http://surgemail.com r=1653887525 Cc: Artemiev Igor Subject: Re: [PATCH] nForce2 SMBus support X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Dec 2005 12:54:11 -0000 On Friday 09 December 2005 06:36 am, Artemiev Igor wrote: > On Thu, 8 Dec 2005 09:51:51 -0500 > > John Baldwin wrote: > > > I simply do not see any way to do it with current implementation of > > > ampdm(and also viapm, etc) & smbus, without modifying the smb- > > > > > > >smbus->smbus driver interface. I may be wrong, but as far as I > > > >know, currently it's one > > > > > > smb for one driver (smbus_* limitation) > > > > Hmm, it doesn't specify the child device, just the parent. *sigh* > > That's lame. You don't have to call it amdpmsub0 btw, you could just > > call it amdpm1 if you wanted and have amdpm1 a child of amdpm0. All > > that would need to change for that is the NF2_SUBDEV string and the > > DRIVER_MODULE line (it would be DRIVER_MODULE(amdpm, amdpm, ...)). > > This has the added advantage that you don't have to patch smbus.c. > > I remade it as you described - can't understand, why I didn't think > about it myself Do you have a final patch at a URL? If so, I'll go ahead and commit it for= =20 you. =2D-=20 John Baldwin =A0<>< =A0http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" =A0=3D =A0http://www.FreeBSD.org