From owner-svn-ports-all@freebsd.org Sat Mar 6 17:52:55 2021 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CA0F156E48E; Sat, 6 Mar 2021 17:52:55 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DtByv5NH6z4d9p; Sat, 6 Mar 2021 17:52:55 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1615053175; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ibDgQW8McWHJweJq2Qii7OD4AH6wgvIAWd8PEo4K7MY=; b=lQJEeAP42Lz4a2A7OG80kC7+SZ+EFTn3E/SKOgFUVlLJ/kEfDr4VfNx7y2bhfhxBDniU/8 Yi9lc4E1l6xo81UzgeJDr3Wobo+xuTm9dtTjkLCVDPj7LrlmiEW1Es+Qtjl7Mvkvsly0dY 03/iwMUxR9wRy45C8RLVNn/2nal5EIAm8XuWf/kypkeJF9r4LrSL4y1Gj3pwfhXbAXuOxc Cx+JNR+oU4lBiAHOXn67UjUjE9/5P7hwx1Xu+3JTBGKZ9qWFkRAYugCcG07KbmvN4g9dL1 59ao0GySgZJiJJEO1z2Smq6bh7T/6xpAw77kIR9QujN6jTtq9n3YQ8/P61uSFQ== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 8EFC219C2C; Sat, 6 Mar 2021 17:52:55 +0000 (UTC) Date: Sat, 6 Mar 2021 17:52:55 +0000 From: Alexey Dokuchaev To: Rainer Hurling Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r561652 - in head/databases: libgda5-mdb mdbtools mdbtools/files recutils Message-ID: <20210306175255.GA23648@FreeBSD.org> References: <202101151716.10FHGPeF016819@repo.freebsd.org> <20210306164305.GA32516@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1615053175; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ibDgQW8McWHJweJq2Qii7OD4AH6wgvIAWd8PEo4K7MY=; b=A5k3Vz7ekGW7v+sIf6zU+swHbelI8zEPsUMXXnp2J+vB0y4BWg/WyUkg/yaSp9eDVqM6xp rWLr2zj1HLzcSiX3jWJZ4WCbDJDNbEvp964S3w7h9lqw2FZxprDoDJR5PqMA6af8o7KP96 JiQaLthJ5Ot2hXoO+/CLksL/kUKyc8/44N1RH++gqroSX252PR/QObmaGRCuY5rjo59Lfe tc+IP2CRzRo+lpO+edIBtR/F1gbpCxeCjv1b/w+f8QPzAR1v6A2hcPTNDI0mETPAoeuy/J NX/Bh4iCxZvEVnQy0CBDmRk3NBaZfCFailcj+gjTITlWgd8MJahEuB8Hiu2xRA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1615053175; a=rsa-sha256; cv=none; b=rX4coVhUyFbxbr3RxIVNwuOt16T3BVpC/5P+XCfSJPZseFQABmr85wchwQnDk5+k4pMY67 R84aFAhf/zbc/Fbk+OO4FQ7DK+rbfnUWpgmnjPtnVzgRS6h0PbNH5NFiUoA87KiCdOSmHg wSYldYCZgDLkC8QCgDnlLfe74YoTQ1sh1nr5r4WbLAjsHz9cJZEpX3qBo+uGsThI3fFzTR 57ZRCZyhKMT1UA5Bc8PSdNkM3rKxjyxPgtyeHC1zuaLwAlBGQ+hEqc8WO5GMzB7q1IaX3o mVS/pTc7wVGgLhovWRBP+ySAOnPnUCyveXeEI+LBrRLDdPzd1Bc4Z/ZBrXGdDA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Mar 2021 17:52:55 -0000 On Sat, Mar 06, 2021 at 06:39:23PM +0100, Rainer Hurling wrote: > Am 06.03.21 um 17:43 schrieb Alexey Dokuchaev: > > On Fri, Jan 15, 2021 at 05:16:25PM +0000, Rainer Hurling wrote: > >> New Revision: 561652 > >> URL: https://svnweb.freebsd.org/changeset/ports/561652 > >> > >> Log: > >> databases/mdbtools: Update to 0.9.1 > >> > >> - Switch to a new fork on Github > >> - Split NLS (gettext) as an option > >> - Remove gmdb2 GUI (will come back as own port) > >> > >> ... > >> Modified: head/databases/mdbtools/Makefile > >> @@ -1,8 +1,8 @@ > >> -# Created by: Anders Nordby > > > > We typically keep these lines out of respect to the original port author > > and appreciation of their efforts. While they are optional for new ports, > > one should not remove them unless under explicit concent of that person. > > Did you obtain that from Anders? > > Yes, you are right. That should not have happened. I will try to be more > careful next time. It's okay, just put it back when you touch the Makefile next time, e.g. during upcoming 0.9.2 update (no need for separate gratuitous commit). > >> PORTNAME= recutils > >> PORTVERSION= 1.8 > >> +PORTREVISION= 1 > > > > You should've checked all consumer ports that they actually can build > > against updated port, no just merely bump port revision, even if this > > dependency is optional and disabled by default. There had been some > > changes in public API so `databases/recutils' failed to build with MDB > > option enabled. I've fixed the port in r567461 and enabled MDB by > > default so this breakage could be caught earlier next time. > > Arghh, that slipped through. > > I'm really sorry to have caused you so much trouble and extra work. It was not really *that* bad, no worries. :) As I've said, it is more exposed now; it's indeed kind of cumbersome to test all those off-by- default options in all the consumers. Keep up the good work! ./danfe