From owner-freebsd-arch@FreeBSD.ORG  Mon Apr 14 07:00:30 2008
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: arch@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9129C106564A
	for <arch@FreeBSD.ORG>; Mon, 14 Apr 2008 07:00:30 +0000 (UTC)
	(envelope-from phk@critter.freebsd.dk)
Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222])
	by mx1.freebsd.org (Postfix) with ESMTP id 35A878FC1E
	for <arch@FreeBSD.ORG>; Mon, 14 Apr 2008 07:00:30 +0000 (UTC)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (unknown [192.168.61.3])
	by phk.freebsd.dk (Postfix) with ESMTP id EAF2F17107;
	Mon, 14 Apr 2008 07:00:28 +0000 (UTC)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.14.2/8.14.2) with ESMTP id m3E70Sp0004994;
	Mon, 14 Apr 2008 07:00:28 GMT (envelope-from phk@critter.freebsd.dk)
To: Jeff Roberson <jroberson@jroberson.net>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Sun, 13 Apr 2008 13:16:59 -1000."
	<20080413131422.V959@desktop> 
Date: Mon, 14 Apr 2008 07:00:28 +0000
Message-ID: <4993.1208156428@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
Cc: arch@FreeBSD.ORG, David Schultz <das@FreeBSD.ORG>
Subject: Re: f_offset 
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Apr 2008 07:00:30 -0000

In message <20080413131422.V959@desktop>, Jeff Roberson writes:

>However, f_offset is fetched and set with a shared vnode lock for readers.

"fetched AND set" with a shared lock ?

How can that possibly work out sanely ?

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.