From owner-svn-src-head@freebsd.org Tue Jul 11 18:55:53 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 79C8CDAA1DF; Tue, 11 Jul 2017 18:55:53 +0000 (UTC) (envelope-from rpokala@mac.com) Received: from mr11p00im-asmtp001.me.com (mr11p00im-asmtp001.me.com [17.110.69.252]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5C285825DD; Tue, 11 Jul 2017 18:55:53 +0000 (UTC) (envelope-from rpokala@mac.com) Received: from process-dkim-sign-daemon.mr11p00im-asmtp001.me.com by mr11p00im-asmtp001.me.com (Oracle Communications Messaging Server 7.0.5.38.0 64bit (built Feb 26 2016)) id <0OSX00N00V89O400@mr11p00im-asmtp001.me.com>; Tue, 11 Jul 2017 18:55:49 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mac.com; s=04042017; t=1499799349; bh=h9Mvba9BO0q+6No1tT1rE36WSFgFJW2D0zt86797MlA=; h=Date:Subject:From:To:Message-id:MIME-version:Content-type; b=UY3ZhReSZ9zh4algQZ1k7J7Aft+VKeiT3IngLJZFrkssMQOq+wcQQcJ+uqGAaRhZ6 sXOEgSdNJ59GG9hsSzBrYGRmrFFTWtyIKrCurrtoABxWO9iCkE21GvmLOtXk0pIyry qNnj52RNdYT3O37KipPacK0FtT33ol9erUNdNyn9t02cZhGcfjupNca3ZaXyzozZq0 KbhwNgxh/nlfHSpSP5gHZgGFWkHDOL7V5GrH7iJ1mzNS/lPkn2fqwjhFXa4UTH385k lLS/826j5TS9eHRsNx6HuDe0LbNeUOVrQtXHWdWG81gfN+bLGOrsJV546ko4YMEdS8 3EIjMTC85/fBg== Received: from icloud.com ([127.0.0.1]) by mr11p00im-asmtp001.me.com (Oracle Communications Messaging Server 7.0.5.38.0 64bit (built Feb 26 2016)) with ESMTPSA id <0OSX00N4HWKYY010@mr11p00im-asmtp001.me.com>; Tue, 11 Jul 2017 18:55:47 +0000 (GMT) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-07-11_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 clxscore=1034 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1701120000 definitions=main-1707110305 User-Agent: Microsoft-MacOutlook/f.21.0.170409 Date: Tue, 11 Jul 2017 11:55:45 -0700 Subject: Re: svn commit: r320892 - head/etc/defaults From: Ravi Pokala To: Edward Napierala Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Message-id: Thread-topic: svn commit: r320892 - head/etc/defaults References: <201707111232.v6BCWeXu073060@repo.freebsd.org> In-reply-to: MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Jul 2017 18:55:53 -0000 So the answer is "magic!" ;-) Fair enough; I'll RTFSource if I'm still sufficiently curious tomorrow. :-) Thanks again, Ravi (rpokala@) -----Original Message----- From: on behalf of Edward Napierala Date: 2017-07-11, Tuesday at 11:46 To: Ravi Pokala Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r320892 - head/etc/defaults Well, fsck(8) is a bit weird. Assuming you don't have /dev/md0 in your fstab(5): [trasz@v2:~]% fsck -d -t ffs -T ufs:-R /dev/md0 start (null) wait fsck_ffs /dev/md0 [trasz@v2:~]% fsck -d -t ufs -T ufs:-R /dev/md0 start (null) wait fsck_ufs -R /dev/md0 However (/ is defined as ufs in my fstab(5)): [trasz@v2:~]% fsck -d -t ffs -T ufs:-R / start / wait fsck_ufs -R /dev/ada0s1a [trasz@v2:~]% fsck -d -t ufs -T ufs:-R / start / wait fsck_ufs -R /dev/ada0s1a 2017-07-11 16:21 GMT+01:00 Ravi Pokala : I appreciate the spirit of this change; thanks Trasz! A question though: you're telling the generic `fsck' to pass "-R" to either `fsck_ffs' or `fsck_ufs', as needed. But those are both names for the same executable. Won't the generic `fsck' always end up invoking (per sbin/fsck/fsck.c::ptype_map[]) `fsck_ffs'? In which case, is the `fsck_ufs' case needed here? Thanks, Ravi (rpokala@) -----Original Message----- From: on behalf of Edward Tomasz Napierala Date: 2017-07-11, Tuesday at 05:32 To: , , Subject: svn commit: r320892 - head/etc/defaults Author: trasz Date: Tue Jul 11 12:32:40 2017 New Revision: 320892 URL: https://svnweb.freebsd.org/changeset/base/320892 Log: Make fsck_y_enable default to passing pass -R to fsck_ffs(8) in addition to -y. To me, fsck_y_enable means "try as hard as possible", and without -R, it... well, doesn't. Reviewed by: mckusick Obtained from: CheriBSD MFC after: 2 weeks Sponsored by: DARPA, AFRL Differential Revision: https://reviews.freebsd.org/D11490 Modified: head/etc/defaults/rc.conf Modified: head/etc/defaults/rc.conf ============================================================================== --- head/etc/defaults/rc.conf Tue Jul 11 06:39:12 2017 (r320891) +++ head/etc/defaults/rc.conf Tue Jul 11 12:32:40 2017 (r320892) @@ -92,7 +92,7 @@ geli_autodetach="YES" # Automatically detach on last c root_rw_mount="YES" # Set to NO to inhibit remounting root read-write. root_hold_delay="30" # Time to wait for root mount hold release. fsck_y_enable="NO" # Set to YES to do fsck -y if the initial preen fails. -fsck_y_flags="" # Additional flags for fsck -y +fsck_y_flags="-T ffs:-R -T ufs:-R" # Additional flags for fsck -y background_fsck="YES" # Attempt to run fsck in the background where possible. background_fsck_delay="60" # Time to wait (seconds) before starting the fsck. netfs_types="nfs:NFS smbfs:SMB" # Net filesystems.