From owner-svn-src-head@freebsd.org Tue Oct 27 21:25:55 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BA9F845ABBD for ; Tue, 27 Oct 2020 21:25:55 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qv1-xf2b.google.com (mail-qv1-xf2b.google.com [IPv6:2607:f8b0:4864:20::f2b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CLPrf5dGNz4F8s for ; Tue, 27 Oct 2020 21:25:54 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qv1-xf2b.google.com with SMTP id ev17so1431765qvb.3 for ; Tue, 27 Oct 2020 14:25:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fd3E1MPL9ySXxACGCmvMFwvo9zkss4vhXHFDc57547E=; b=MtzYV1+kNndKj5JXHakGZ0SHFpwZPdHq6fCH/yHfIa7tC742gAhkZ3TZ3kdWGEW160 FFbixw2QfUl0jVdOFekINavMfKUE3iU+fYwX4hMFTqRTtdXYFnlsVdp8kneeCaJ3F4os QoaFvDkZ4fREWHbEQ/zAuPcI8Oi3NRf3Pqxxjrzl1tE/gX5toAi4fV3yFPXu0wAo0UQp PDLO7QI1wSDQtTU/OuSGXsxO11NiQ3bZKGfSsnNPM2+LQVoN4s4Llo3pAfPGO6BAcZw6 vb/duQ/i0ms6I1iNNg+KRyPYB5FFIWGhDdZnNIdk73LnvpcUfx0gb5Q4j011pLSNCKYI FSnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fd3E1MPL9ySXxACGCmvMFwvo9zkss4vhXHFDc57547E=; b=h1ZcobrEgaXlc8a2TqXDz25nutkUjOY2r9nfJcjxDaV9tZNWApY5qtqVs8uSKLmJyf U2m0frIQps3jcY8YEEJG+s/oT59tjf4DYaYqf2IS92ZUDpdihnUvW7abzi67XoExL+19 YGwqVw/YV+sePkAfRvXp9VNAC8Mii02IL1P2upfmVPSO0/zNkFfwPuI2jqLeV3M296nq KFK+VoUmMe8o8dbnttI71U/n4P9ZQDDYeh+OHFOM1lDqGgrhXWV65gYC70JmwlrpcAxd EUITBjnF2sIlBgSgCA3BynWga3rfnakRD0T8WowQ7IymTMMIrprp4eCHGkz3XDQfpuY2 LQlg== X-Gm-Message-State: AOAM5325Bi3kfhxVIt+uJgMVJz1rlaQ2cuCeToRM9xF6ysRUk6CihQma B/NxdtjFa9Lionl5TElVYsYGacXtGTB5vSqt3eLTRQ== X-Google-Smtp-Source: ABdhPJxPIgIui23CvxYppOO1AkVR/bLwTQrMY9GaMdTuy05i+tCd2zQN530EvS9Wqy7XltK+Vxiop9UzWfWTpH0qp5s= X-Received: by 2002:a05:6214:10c4:: with SMTP id r4mr4416960qvs.62.1603833953715; Tue, 27 Oct 2020 14:25:53 -0700 (PDT) MIME-Version: 1.0 References: <202010241023.09OANMcL075640@repo.freebsd.org> <20201024104628.GB2643@kib.kiev.ua> <20201027202306.GQ2643@kib.kiev.ua> In-Reply-To: <20201027202306.GQ2643@kib.kiev.ua> From: Warner Losh Date: Tue, 27 Oct 2020 15:25:42 -0600 Message-ID: Subject: Re: svn commit: r366993 - head/sys/net To: Konstantin Belousov Cc: Ed Maste , Hans Petter Selasky , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 4CLPrf5dGNz4F8s X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=MtzYV1+k; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::f2b) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-2.48 / 15.00]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; NEURAL_HAM_MEDIUM(-0.98)[-0.983]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-0.96)[-0.959]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-head@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; RCPT_COUNT_FIVE(0.00)[6]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; NEURAL_HAM_SHORT(-0.54)[-0.541]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::f2b:from]; R_SPF_NA(0.00)[no SPF record]; FREEMAIL_TO(0.00)[gmail.com]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; MAILMAN_DEST(0.00)[svn-src-head] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Oct 2020 21:25:55 -0000 On Tue, Oct 27, 2020 at 2:23 PM Konstantin Belousov wrote: > On Tue, Oct 27, 2020 at 02:52:38PM -0400, Ed Maste wrote: > > On Sat, 24 Oct 2020 at 06:46, Konstantin Belousov > wrote: > > > > > > > -#include > > > sys/systm.h should come right after sys/param.h. These two headers are > > > exceptions to the normal alphabetical rule. > > > > style(9) claims that sys/types.h and sys/param.h are the special headers: > > > > Kernel include files (sys/*.h) come first. If is > needed > > for __FBSDID(), include it first. If either or > > is needed, include it before other include files. > > ( includes ; do not include both.) The > > remaining kernel headers should be sorted alphabetically. > > > > We should add sys/systm.h to style(9) as another special case if > necessary. > Yes sys/systm.h is very special because it defines a lot of basic things, > like asserts, printf(9), and so on, and because it includes enough other > popular headers. Its intent is to gather all common stuff, which makes > it both convenient and necessary to go before other (but sys/param.h is > more > prioritized). > So sorted after sys/types.h or sys/param.h should be documented in style(9). https://reviews.freebsd.org/D26981 has a proposed change. Warner > > > > > > -infiniband_ipv4_multicast_map(uint32_t addr, > > > > - const uint8_t *broadcast, uint8_t *buf) > > > > +infiniband_ipv4_multicast_map( > > > > + uint32_t addr, const uint8_t *broadcast, uint8_t *buf) > > > And this is arguably regression, we fill line up to columns 72-80 > before > > > splitting to the continuation line. > > > > I agree with kib and arichardson has a clang-format fix for this in > > D26978. That said I can see an argument for it being easier to read > > with all function args on the same line. > > > > > > - m = NULL; /* mbuf is consumed by > resolver */ > > > > + m = NULL; /* mbuf is consumed by > resolver */ > > > This is a regression as well, in-line comment is typically preceeded > by tab. > > > > I suspect this is hard to do in an automated fashion in a way that's > > sensible overall (i.e., lining up inline comments on different lines). > > > > This could be a case where we decide to just accept it when someone > > uses clang-format on new code, and just discourage sweeping > > clang-format changes on existing code. >