From owner-p4-projects@FreeBSD.ORG  Wed Feb  4 14:12:12 2009
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id B057010656C0; Wed,  4 Feb 2009 14:12:12 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 656F71065698;
	Wed,  4 Feb 2009 14:12:12 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
Received: from swip.net (mailfe04.swip.net [212.247.154.97])
	by mx1.freebsd.org (Postfix) with ESMTP id C0DF48FC14;
	Wed,  4 Feb 2009 14:12:11 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
X-Cloudmark-Score: 0.000000 []
X-Cloudmark-Analysis: v=1.0 c=1 a=0KBuQ0Py0AsA:10 a=vJfZpIWdE3N5OeBeko8A:9
	a=O1i1IH5xeNOpVb9hRBMA:7 a=vgQ8i8LXVMoHKX_azwXA3t-HrBoA:4
	a=LY0hPdMaydYA:10
Received: from [85.19.218.115] (account mc467741@c2i.net HELO [10.37.1.92])
	by mailfe04.swip.net (CommuniGate Pro SMTP 5.2.6)
	with ESMTPA id 1190470165; Wed, 04 Feb 2009 14:57:10 +0100
From: Hans Petter Selasky <hselasky@c2i.net>
To: Weongyo Jeong <weongyo@freebsd.org>
Date: Wed, 4 Feb 2009 14:59:35 +0100
User-Agent: KMail/1.9.7
References: <200902041242.n14CgXj2014958@repoman.freebsd.org>
In-Reply-To: <200902041242.n14CgXj2014958@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Message-Id: <200902041459.35445.hselasky@c2i.net>
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 157132 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Feb 2009 14:12:14 -0000

On Wednesday 04 February 2009, Weongyo Jeong wrote:
> =A0=A0=A0=A0=A0=A0=A0=A0bzero(desc, sizeof(struct uath_tx_desc));
> =A0=A0=A0=A0=A0=A0=A0=A0desc->msglen =3D htobe32(sizeof(struct uath_tx_de=
sc));
> -=A0=A0=A0=A0=A0=A0=A0desc->msgid =A0=3D data_idx + 1;=A0=A0=A0=A0/* don'=
t care about endianness */
> +=A0=A0=A0=A0=A0=A0=A0desc->msgid =A0=3D (sc->sc_msgid++) + 1;=A0=A0=A0=
=A0/* don't care about
> endianness */ desc->type =A0 =3D htobe32(WDCMSG_FLUSH);
> =A0=A0=A0=A0=A0=A0=A0=A0desc->txqid =A0=3D htobe32(0);
> =A0=A0=A0=A0=A0=A0=A0=A0desc->connid =3D htobe32(0);

Why not allocate an mbuf to hold the "descriptor" data. Then you use the=20
m_next field of the header mbuf to link with the "data" mbuf ? Then you onl=
y=20
need one [mbuf] queue for TX ? You can look at if_ural2.c and if_rum2.c=20
in /sys/dev/usb2/wlan .

=2D-HPS