From owner-svn-src-head@freebsd.org  Thu Apr 19 03:38:01 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id A103CFA3FB7;
 Thu, 19 Apr 2018 03:38:01 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: from smtp.freebsd.org (unknown [IPv6:2610:1c1:1:606c::24b:4])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id C906973439;
 Thu, 19 Apr 2018 03:38:00 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: from mail-lf0-f52.google.com (mail-lf0-f52.google.com
 [209.85.215.52])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 (Authenticated sender: kevans)
 by smtp.freebsd.org (Postfix) with ESMTPSA id 78E171C239;
 Thu, 19 Apr 2018 03:38:00 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: by mail-lf0-f52.google.com with SMTP id z130-v6so5637928lff.5;
 Wed, 18 Apr 2018 20:38:00 -0700 (PDT)
X-Gm-Message-State: ALQs6tCZwdsKFEYlzweerhk8fqMEZqSiM7IwRxe2j60E8GbGv7z8FQy5
 /D03F+kt0d2YOfBOwFO8ZX0HMXh8NS22hVNSHSg=
X-Google-Smtp-Source: AIpwx4+4FKb6+06Lhl2BfUIz8N2HqtF7xhmtWEIGaEsY+FgF3x3Iua8v7R+uFkRO+lIwYeXY7FlXF4WHHsdgCd2RyS4=
X-Received: by 2002:a19:d850:: with SMTP id
 p77-v6mr2919878lfg.52.1524109079015; 
 Wed, 18 Apr 2018 20:37:59 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.46.129.90 with HTTP; Wed, 18 Apr 2018 20:37:38 -0700 (PDT)
In-Reply-To: <201804190331.w3J3VgaA001507@repo.freebsd.org>
References: <201804190331.w3J3VgaA001507@repo.freebsd.org>
From: Kyle Evans <kevans@freebsd.org>
Date: Wed, 18 Apr 2018 22:37:38 -0500
X-Gmail-Original-Message-ID: <CACNAnaFdf0WDb-FXEb7NK6RuLW5jv2-Oa=4=9EXmXRm1yWXMLw@mail.gmail.com>
Message-ID: <CACNAnaFdf0WDb-FXEb7NK6RuLW5jv2-Oa=4=9EXmXRm1yWXMLw@mail.gmail.com>
Subject: Re: svn commit: r332751 - in head/stand/efi: boot1 loader
To: Kyle Evans <kevans@freebsd.org>
Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, 
 svn-src-head@freebsd.org
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Apr 2018 03:38:01 -0000

On Wed, Apr 18, 2018 at 10:31 PM, Kyle Evans <kevans@freebsd.org> wrote:
> Author: kevans
> Date: Thu Apr 19 03:31:41 2018
> New Revision: 332751
> URL: https://svnweb.freebsd.org/changeset/base/332751
>
> Log:
>   efi loader: Address two nits with recent graphics changes
>
>   - We should be setting a known graphics mode on conout, but we aren't.

This should read "known text mode," and mode 0 was chosen simply
because it's defined by the standard to be available (and 80x25).

>   - We shouldn't be setting gop mode if we didn't find a good resolution to
>     set, but we were. This made efi_max_resolution=1x1 effectively worthless,
>     since it would always set gop mode 0 if nothing else.
>
> Modified:
>   head/stand/efi/boot1/boot1.c
>   head/stand/efi/loader/framebuffer.c
>
> Modified: head/stand/efi/boot1/boot1.c