From owner-cvs-CVSROOT  Sun Sep  7 22:36:09 1997
Return-Path: <owner-cvs-cvsroot>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.7/8.8.7) id WAA08089
          for cvs-CVSROOT-outgoing; Sun, 7 Sep 1997 22:36:09 -0700 (PDT)
Received: from critter.freebsd.dk (critter.freebsd.dk [195.8.129.19])
          by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id WAA08081;
          Sun, 7 Sep 1997 22:36:05 -0700 (PDT)
Received: from critter.freebsd.dk (localhost.cybercity.dk [127.0.0.1])
	by critter.freebsd.dk (8.8.7/8.8.7) with ESMTP id HAA11171;
	Mon, 8 Sep 1997 07:34:21 +0200 (CEST)
To: Steve Passe <smp@csn.net>
cc: smp@freebsd.org, cvs-committers@freebsd.org, cvs-all@freebsd.org,
        cvs-CVSROOT@freebsd.org
Subject: Re: machine/up.h 
In-reply-to: Your message of "Sun, 07 Sep 1997 14:37:40 MDT."
             <199709072037.OAA27121@Ilsa.StevesCafe.com> 
Date: Mon, 08 Sep 1997 07:34:19 +0200
Message-ID: <11169.873696859@critter.freebsd.dk>
From: Poul-Henning Kamp <phk@critter.freebsd.dk>
Sender: owner-cvs-cvsroot@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk


Why not simply have the code do a

#include <machine/smp.h>

and in that file have

#ifdef SMP
#define THIS_STUFF (lkjsdfgskdj)
#define THAT_STUFF (lkjsdfgskdj)
#else /* !SMP */
#define THIS_STUFF /* Nothing */
#define THAT_STUFF /* Nothing */
#endif


In message <199709072037.OAA27121@Ilsa.StevesCafe.com>, Steve Passe writes:
>Hi,
>
>I propose that we create an alternate file to smp.h named up.h.
>
>code could then look like:
>
>#ifdef SMP
>#include <machine/smp.h>
>#else
>#include <machine/up.h>
>#endif
>
>I could then move stuff like:
>
>#ifndef SMP
>#define THIS_LOCK	/* nop this out for UP */
>#define THAT_FEATURE	/* nop this out for UP */
>#endif
>
>from individual files and gather them all up into up.h  This should cause less
>disturbance to the source tree than the current methods.
>
>Any objections?
>
>
>--
>Steve Passe	| powered by
>smp@csn.net	|            Symmetric MultiProcessor FreeBSD
>
>

--
Poul-Henning Kamp             FreeBSD coreteam member
phk@FreeBSD.ORG               "Real hackers run -current on their laptop."