From owner-freebsd-ports  Tue Mar 30 15:31:36 1999
Delivered-To: freebsd-ports@freebsd.org
Received: from stampede.cs.berkeley.edu (stampede.CS.Berkeley.EDU [128.32.45.124])
	by hub.freebsd.org (Postfix) with ESMTP id 61EDD14F77
	for <freebsd-ports@FreeBSD.ORG>; Tue, 30 Mar 1999 15:31:35 -0800 (PST)
	(envelope-from asami@cs.berkeley.edu)
Received: from silvia.hip.berkeley.edu ([207.92.173.144]) by stampede.cs.berkeley.edu (8.8.7/8.7.3) with ESMTP id PAA16243; Tue, 30 Mar 1999 15:31:23 -0800 (PST)
Received: (from asami@localhost) by silvia.hip.berkeley.edu (8.9.2/8.6.9) id PAA45505; Tue, 30 Mar 1999 15:30:42 -0800 (PST)
Date: Tue, 30 Mar 1999 15:30:42 -0800 (PST)
Message-Id: <199903302330.PAA45505@silvia.hip.berkeley.edu>
X-Authentication-Warning: silvia.hip.berkeley.edu: asami set sender to asami@cs.berkeley.edu using -f
To: tom@eborcom.com
Cc: freebsd-ports@FreeBSD.ORG
In-reply-to: <19990330172006.A18680@eborcom.com> (message from Tom Hukins on
	Tue, 30 Mar 1999 17:20:06 +0100)
Subject: Re: Problems with p5-* ports
From: asami@FreeBSD.ORG (Satoshi - the Wraith - Asami)
References: <19990322162220.A6658@eborcom.com> <Pine.HPP.3.96.990322152834.10524C-100000@hp9000.chc-chimes.com> <19990330172006.A18680@eborcom.com>
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

 * From: Tom Hukins <tom@eborcom.com>

 * I'd appreciate comments from the Ports Wraith on this. Is there any
 * chance of something like this finding its way into bsd.port.mk?

"Ports Wraith"? ;)

 * +.if defined(PERL5_MODULE)
 * +MAN3PREFIX?=	${PREFIX}/lib/perl5/${PERL_VERSION}
 * +USE_PERL5=	yes
 * +.endif
 * +

Good.

 * +.if defined(PERL5_MODULE)
 * +	@(cd ${WRKSRC} && \
 * +	${SETENV} ${MAKE_ENV} ${PERL} Makefile.PL PREFIX=${PREFIX} \
 * +		INSTALLMAN1DIR=${PREFIX}/man/man1 \
 * +		INSTALLSCRIPT=${PREFIX}/bin)
 * +.endif

I'm not sure if this is good.  I've seen many different combinations
of settings, and some USE_PERL5 ports don't even have this line.

 *  .if make(real-extract)
 * +	@cd ${.CURDIR} && ${MAKE} ${.MAKEFLAGS} build-depends lib-depends perl5-depends misc-depends
 *  .if make(real-install)
 * +	@cd ${.CURDIR} && ${MAKE} ${.MAKEFLAGS} run-depends lib-depends perl5-depends

Ok.

 * +perl5-depends:
 * +.if defined(PERL5_DEPENDS)
 * +.if !defined(NO_DEPENDS)
 * +	@for i in ${PERL5_DEPENDS}; do \
 * +		lib=`${ECHO} $$i | ${SED} -e 's/\..*//' | ${SED} -e 's!/!::!g'`; \
 * +		version=`${ECHO} $$i | ${SED} -e 's/[^\.]*\.//' | ${SED} -e 's/:.*//'`; \
 * +		dir=`${ECHO} $$i | ${SED} -e 's/[^:]*://'`; \

Where's "target" defined?  (Did you test this patch?)

 * +			${ECHO_MSG} "===>    Verifying $$target for $$lib in $$dir"; \

I don't know perl jargon but the rest looks ok.

-PW


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message