From owner-freebsd-git@freebsd.org Mon Dec 28 18:38:16 2020 Return-Path: Delivered-To: freebsd-git@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2943F4BD9D8 for ; Mon, 28 Dec 2020 18:38:16 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4D4RBc0MyKz4YYD for ; Mon, 28 Dec 2020 18:38:16 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id D8C3E4BD83C; Mon, 28 Dec 2020 18:38:15 +0000 (UTC) Delivered-To: git@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D22884BD9D7 for ; Mon, 28 Dec 2020 18:38:15 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D4RBb3ScNz4YQ5; Mon, 28 Dec 2020 18:38:15 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.16.1/8.16.1) with ESMTPS id 0BSIG772007859 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Mon, 28 Dec 2020 10:16:07 -0800 (PST) (envelope-from glebius@freebsd.org) Received: (from glebius@localhost) by cell.glebi.us (8.16.1/8.16.1/Submit) id 0BSIG7Dd007858; Mon, 28 Dec 2020 10:16:07 -0800 (PST) (envelope-from glebius@freebsd.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@freebsd.org using -f Date: Mon, 28 Dec 2020 10:16:07 -0800 From: Gleb Smirnoff To: Ulrich =?iso-8859-1?Q?Sp=F6rlein?= Cc: git@freebsd.org Subject: Re: Please review: suggested final merge commit on the legacy repo Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 4D4RBb3ScNz4YQ5 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: freebsd-git@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussion of git use in the FreeBSD project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Dec 2020 18:38:16 -0000 Ulrich, your commit also looks good to me. On Sun, Dec 27, 2020 at 09:43:03PM +0100, Ulrich Spörlein wrote: U> Thanks Gleb, U> U> I think the "centering" on the first line needs to go, it might confuse U> people's git log output. U> U> Furthermore, we're advocating for "freebsd" as the origin name, not U> "FreeBSD". Even more, we don't want folks to rename their remote, as U> we'll be re-using the GH remote, so they need to explictly add a legacy U> one, no? U> U> I did a test run of merge-based and rebase-based histories earlier today U> and jotted down my notes in U> https://github.com/freebsd/git_conv/wiki/Rebase---Merge-experiments , U> though there's nothing in there you don't already know. U> U> We should probably also make it clear that going forward, one should try U> to branch from a fresh main, and not schlepp around every commit twice U> :( U> U> I'll update the wiki page with the recommendation in a bit. I also U> wonder if we really should make this a merge commit, or a regular U> commit. From my notes above, it's actually rather easy to merge in U> legacy-master, then main-as-of-3cc0c0d66a06 and then main. The first U> step needs to be done anyway, the 2nd is guaranteed to be conflict free U> and the third step is just another regular merge-from-head. And people U> that merge in stable/X need to do this anyway. U> U> Also missing is a way for them to reach out for more help, the link to U> the wiki might give some folks ideas, but I think we can be more U> explicit here. U> U> I've inlined the short set of commands required that should work for U> main and stable (and have tested some of them, though I'm less sure U> about the various upstream magic that happens with git rebase, as one U> can elect to not provide half the refs) U> U> Please see the latest commit on https://github.com/uqs/freebsd U> U> Thanks U> Uli U> U> > U> >-- U> >Gleb Smirnoff U> U> >commit 11f284b67940bcacb2f618858b901e9254ef5992 U> >Merge: 9e4440ca5ba7 3cc0c0d66a06 U> >Author: Gleb Smirnoff U> >AuthorDate: Wed Dec 23 22:44:48 2020 -0800 U> >Commit: Gleb Smirnoff U> >CommitDate: Sun Dec 27 09:15:53 2020 -0800 U> > U> > !!! IMPORTANT ANNOUNCEMENT !!! U> > U> > This commit is the last commit to the legacy FreeBSD github mirror, that U> > used to import data from official FreeBSD subversion and resided at U> > https://github.com/freebsd/freebsd.git. U> > U> > The new FreeBSD github mirror imports data from official FreeBSD git. The U> > history in the new git tree is different to the legacy one. Thus, if you U> > were using the legacy tree to base your work on, you need to migrate. U> > U> > This commit merges the legacy tree and the new tree together. This will U> > allow you to migrate without rebasing. Once you pulled in this commit U> > and merged it to your tree, you need to switch to the new remote and U> > from now on merge from it. The following example assumes your current U> > remote for FreeBSD is named 'FreeBSD': U> > U> > % git remote rename FreeBSD legacy U> > % git remote add FreeBSD anongit@git.freebsd.org:src.git U> > % git fetch legacy/master U> > % git rev-parse legacy/master # shall return this commit! U> > % git merge legacy/master # the last merge from legacy U> > % git remote delete legacy U> > % git fetch FreeBSD/main U> > % git merge FreeBSD/main # the way to merge from now on U> > % git gc # you may want to run this once after the first merge U> > U> > Please consult with U> > U> > https://github.com/freebsd/git_conv/wiki/Migrating-merge-based-project-from-legacy-git-tree U> > U> > for any changes for the above instructions in the future. U> > U> -- Gleb Smirnoff