From owner-freebsd-bugs Wed May 23 13:50: 8 2001 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 880A237B42C for ; Wed, 23 May 2001 13:50:02 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.11.1/8.11.1) id f4NKo2w21337; Wed, 23 May 2001 13:50:02 -0700 (PDT) (envelope-from gnats) Received: from xkulesh.vol.cz (xkulesh.vol.cz [195.250.154.106]) by hub.freebsd.org (Postfix) with ESMTP id 3179E37B43E for ; Wed, 23 May 2001 13:48:31 -0700 (PDT) (envelope-from dan@xkulesh.vol.cz) Received: (from root@localhost) by xkulesh.vol.cz (8.11.3/8.11.3) id f4NKmL000775; Wed, 23 May 2001 22:48:21 +0200 (CEST) (envelope-from dan) Message-Id: <200105232048.f4NKmL000775@xkulesh.vol.cz> Date: Wed, 23 May 2001 22:48:21 +0200 (CEST) From: dan@obluda.cz Reply-To: dan@obluda.cz To: FreeBSD-gnats-submit@freebsd.org X-Send-Pr-Version: 3.113 Subject: kern/27598: SMB complain about SMP Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org >Number: 27598 >Category: kern >Synopsis: netsmb can't be kldloaded in SMP environment >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed May 23 13:50:01 PDT 2001 >Closed-Date: >Last-Modified: >Originator: Dan Lukes >Release: FreeBSD 4.3-STABLE i386 >Organization: Obludarium >Environment: System: FreeBSD xkulesh.vol.cz 4.3-STABLE FreeBSD 4.3-STABLE #18: Wed May 23 21:18:28 CEST 2001 dan@xkulesh.vol.cz:/usr/src/sys/compile/Dan i386 SMP hardware, SMP kernel, LIBICONV compiled in kernel, kldloaded libmchain STABLE CVSUPped od May 22 >Description: when I use kldload smbfs, the following messages appear on console: --------- error: module compiled without SMP support netsmb_dev: unloaded module_register_init: MOD_LOAD (dev_netsmb, c0c251a0, 0) error 1 error: module compiled without SMP support --------- despite of it, smbfs is loaded >How-To-Repeat: see environment and description >Fix: I'm not sure about correct fix, because I'm not sure if netsmb and/or smbfs is SMP sensitive and SMP ready. sys/netsmb/smb_dev.c call the smb_checksmp() which is implemented in sys/netsmb/smb_subr.c smb_subr.c use SMP variable (#define), but doesn't #include opt_global.h where SMP is defined No file in sys/netsmb nor sys/fs/smbfs seems to contain a SMP specific code other than (ever failing) test (there are no code using number of CPU's nor ifdef-ed with SMP variable). So, there are three posibilities: 1. netsmb/smbfs isn't SMP sensitive - lets completelly remove redundant test 2. netsmp/smbfs is SMP sensitive, but not SMP ready - lets change error message to something more true 3. netsmp/smbfs is SMB sensitive and is SMP ready (and I miss something) - lets include opt_global.h to (at least) smb_subr.c it give chance to test to work properly >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message