From owner-freebsd-current@freebsd.org Sun Dec 20 02:05:12 2015 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id ACBA0A4C2A7 for ; Sun, 20 Dec 2015 02:05:12 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x22f.google.com (mail-pf0-x22f.google.com [IPv6:2607:f8b0:400e:c00::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 855D51CE5; Sun, 20 Dec 2015 02:05:12 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x22f.google.com with SMTP id v86so69168305pfa.2; Sat, 19 Dec 2015 18:05:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=ODne0ZVeuYplsGEbGpynjOHsHtTeC5qiNEPJR9CQFeE=; b=G4YnXDAfJgk8i5PUDl0iriI8Rz2T2qpZ8g6RK4QYPtFQwDFL+jYXF3KRiNWBa/X2ym 8lRo1tAW2BUcheX75rMQn79oA2e6x25TgYSq7y/O3hiAvH44qvfionG9tJhYRmEUxF0C rIm0s5r6vFCVzm6uTgjvRqt/Cylz8jILwNKvk9QZgeJ1RIlXPV+slmmzQBvwAf4g7EUO ZvxlLGncTBONLNqDTV9DMB9c2LMdp4upIshyXOPhFTC8O86FvvOmR55LY1p7uzASDMis NCTknEXIyw+bp3yEsgdIL0xYdFcPWGMk4I5OlBz5iEX8ScFz7iKMCN77sJpfxWutcdLI y8MA== X-Received: by 10.98.14.145 with SMTP id 17mr16844934pfo.145.1450577112093; Sat, 19 Dec 2015 18:05:12 -0800 (PST) Received: from [192.168.20.7] (c-24-16-212-205.hsd1.wa.comcast.net. [24.16.212.205]) by smtp.gmail.com with ESMTPSA id v17sm5836388pfi.17.2015.12.19.18.05.10 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 19 Dec 2015 18:05:10 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Subject: Re: Build error on i386 when building dtrace tests From: NGie Cooper In-Reply-To: <20151220015735.GA48337@charmander> Date: Sat, 19 Dec 2015 18:05:09 -0800 Cc: FreeBSD CURRENT , Bryan Drewery Content-Transfer-Encoding: quoted-printable Message-Id: <6ABCF474-EFF6-493F-ADE3-88A8D7F7186D@gmail.com> References: <468DF7A4-47F9-4460-A41F-226A799EA645@gmail.com> <20151220015735.GA48337@charmander> To: Mark Johnston X-Mailer: Apple Mail (2.2104) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Dec 2015 02:05:12 -0000 (fixed the subject line again..) > On Dec 19, 2015, at 17:57, Mark Johnston wrote: >=20 > On Sat, Dec 19, 2015 at 05:03:51PM -0800, NGie Cooper wrote: >> Hi Mark, >> I ran into the following error when trying to build the dtrace = tests on i386 (both with 10.2-RELEASE-p7 and 11.0-CURRENT) =E2=80=94 = have you seen this issue before? >=20 > Yes, that's because drti.o in stable/10 depends on libelf. The change > which removes the libelf dependency shouldn't be MFCed because it = breaks > compatibility. When building an MFCed test suite on stable/10, you'll > need to link the test programs against libelf. When building current = on > stable/10, dtrace(1) should use the drti.o from the objdir rather than > the installed base. The diff below should solve these two problems. >=20 > diff --git a/cddl/usr.sbin/dtrace/tests/dtrace.test.mk = b/cddl/usr.sbin/dtrace/tests/dtrace.test.mk > index 0c528ef..dcec33a 100644 > --- a/cddl/usr.sbin/dtrace/tests/dtrace.test.mk > +++ b/cddl/usr.sbin/dtrace/tests/dtrace.test.mk > @@ -30,6 +30,8 @@ SRCS.${prog}+=3D ${prog:S/.exe$/.c/} >=20 > .if exists(${prog:S/^tst.//:S/.exe$/.d/}) > SRCS.${prog}+=3D ${prog:S/^tst.//:S/.exe$/.d/} > +LDADD.${prog}+=3D -lelf > +DPADD.${prog}+=3D ${LIBELF} > .endif > .endfor >=20 > diff --git a/share/mk/sys.mk b/share/mk/sys.mk > index 8fe6b68..1eeb0b9 100644 > --- a/share/mk/sys.mk > +++ b/share/mk/sys.mk > @@ -128,7 +128,7 @@ CXXFLAGS ?=3D = ${CFLAGS:N-std=3D*:N-Wnested-externs:N-W*-prototypes:N-Wno-pointer-sig > PO_CXXFLAGS ?=3D ${CXXFLAGS} >=20 > DTRACE ?=3D dtrace > -DTRACEFLAGS ?=3D -C -x nolibs > +DTRACEFLAGS ?=3D -C -x nolibs -x libdir=3D${.OBJDIR}/cddl/lib/drti >=20 > .if empty(.MAKEFLAGS:M-s) > ECHO ?=3D echo I was still running into this issue with the dtrace testcases on = CURRENT. Once I cleaned out the directories (cddl/=E2=80=A6) with make = cleandir, things worked =E2=80=94 huh=E2=80=A6 it seems like things are = broken in the build system in subtle ways based on this issue and the = other libkvm weirdness with rescue/rescue :/.. Thanks, -NGie=