From owner-freebsd-hackers@FreeBSD.ORG  Fri Jan 18 17:13:13 2013
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id CB29946B;
 Fri, 18 Jan 2013 17:13:13 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net
 [IPv6:2001:470:1f10:75::2])
 by mx1.freebsd.org (Postfix) with ESMTP id AAC84889;
 Fri, 18 Jan 2013 17:13:13 +0000 (UTC)
Received: from pakbsde14.localnet (unknown [38.105.238.108])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id 0AB00B993;
 Fri, 18 Jan 2013 12:13:13 -0500 (EST)
From: John Baldwin <jhb@freebsd.org>
To: freebsd-hackers@freebsd.org
Subject: Re: Fixing grep -D skip
Date: Fri, 18 Jan 2013 11:39:00 -0500
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p22; KDE/4.5.5; amd64; ; )
References: <50F8B491.8090303@freebsd.org>
In-Reply-To: <50F8B491.8090303@freebsd.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201301181139.00910.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Fri, 18 Jan 2013 12:13:13 -0500 (EST)
Cc: David Xu <davidxu@freebsd.org>
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
 <freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
 <mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Jan 2013 17:13:13 -0000

On Thursday, January 17, 2013 9:33:53 pm David Xu wrote:
> I am trying to fix a bug in GNU grep, the bug is if you
> want to skip FIFO file, it will not work, for example:
> 
> grep -D skip aaa .
> 
> it will be stucked on a FIFO file.
> 
> Here is the patch:
> http://people.freebsd.org/~davidxu/patch/grep.c.diff2
> 
> Is it fine to be committed ?

I think the first part definitely looks fine.  My guess is the non-blocking 
change is als probably fine, but that should be run by the bsdgrep person at 
least.

-- 
John Baldwin