From owner-freebsd-current@FreeBSD.ORG Mon Aug 31 23:27:38 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C1BF6106566B for ; Mon, 31 Aug 2009 23:27:38 +0000 (UTC) (envelope-from grosser@fim.uni-passau.de) Received: from smtprelay05.ispgateway.de (smtprelay05.ispgateway.de [80.67.18.43]) by mx1.freebsd.org (Postfix) with ESMTP id 40C908FC08 for ; Mon, 31 Aug 2009 23:27:38 +0000 (UTC) Received: from [84.56.34.153] (helo=[192.168.178.32]) by smtprelay05.ispgateway.de with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.68) (envelope-from ) id 1MiGH6-0003od-Ix; Tue, 01 Sep 2009 01:27:36 +0200 From: Tobias Grosser To: ticso@cicely.de In-Reply-To: <11278_1251745674_4A9C1F89_11278_90_1_20090831190735.GF60240@cicely7.cicely.de> References: <1251570251.1238.21.camel@localhost> <19936_1251649540_4A9AA804_19936_425_1_200908301825.57281.hselasky@c2i.net> <1251650741.1187.1.camel@localhost> <200908301909.30692.hselasky@c2i.net> <16272_1251712358_4A9B9D66_16272_77_1_20090831095231.GD59032@cicely7.cicely.de> <1251737958.1216.15.camel@localhost> <11278_1251745674_4A9C1F89_11278_90_1_20090831190735.GF60240@cicely7.cicely.de> Content-Type: multipart/mixed; boundary="=-65egvB1PoKNSGJJbjYrX" Date: Tue, 01 Sep 2009 01:26:57 +0200 Message-Id: <1251761217.1186.9.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 FreeBSD GNOME Team Port X-Df-Sender: imapboxtobias@web-wahnsinn.de Cc: freebsd-current@freebsd.org, Hans Petter Selasky Subject: Re: [PATCH] USB Harddrive not recognized (umass appears, da0 not) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Aug 2009 23:27:38 -0000 --=-65egvB1PoKNSGJJbjYrX Content-Type: text/plain Content-Transfer-Encoding: 7bit On Mon, 2009-08-31 at 21:07 +0200, Bernd Walter wrote: > On Mon, Aug 31, 2009 at 06:59:18PM +0200, Tobias Grosser wrote: > > On Mon, 2009-08-31 at 11:52 +0200, Bernd Walter wrote: > > > On Sun, Aug 30, 2009 at 07:09:29PM +0200, Hans Petter Selasky wrote: > > > > Hi, > > > > > > > > I looks like your device is hanging on SCSI command 0x12,00,00,00,4a,00 > > > > > > 0x12 is an inquiry, which is bad if the device has problems with. > > > > I tried Linux on the same computer and the drive worked without any > > problems. > > > > If those are timestamps then there is a 5 second delay. > I wouldn't say that this is without problems. > Maybe Linux just has a different handling of the case. > > > --------------------------------------- > > linux_dmesg.log is attached. > > --------------------------------------- > > > > There was also another report where the drive did not work on FreeBSD. I > > mailed the user and he did not get it to run on FreeBSD, but his drive > > also works on Linux. > > > > http://lists.freebsd.org/pipermail/freebsd-stable/2006-September/028999.html > > > > As I have two of these drives, I am pretty sure my device is not > > completely broken, but WD has some uncommon/broken way to interact with > > FreeBSD. > > > > To narrow it down I run the usb.org compliance test utility. > > > > http://www.usb.org/developers/tools/ : USB20CV R1.3.5.5 > > As Hans Petter said: this is not a USB problem, it is at SCSI. > > > The results for the generic device test and for the USB mass storage > > test are attached. > > If this is just are startup problem you won't see anything at all after > probing is over. > My assumption would be that the device missbehaves until it spun up. > But this is just an assumption. Thanks to all of you who pointed me in the right direction. It seems the way inquiries are handled was broken. I solved the problem by adding a new quirk for the WD MyPassword Series. Do you think this is the right approach? May this break anything else? And finally if everything is alright, can someone commit this patch? Thanks Tobi --=-65egvB1PoKNSGJJbjYrX Content-Disposition: attachment; filename="umass_western_mypassword.patch" Content-Type: text/x-patch; name="umass_western_mypassword.patch"; charset="us-ascii" Content-Transfer-Encoding: 7bit diff --git a/sys/dev/usb/storage/umass.c b/sys/dev/usb/storage/umass.c index 2e412d9..00f1baa 100644 --- a/sys/dev/usb/storage/umass.c +++ b/sys/dev/usb/storage/umass.c @@ -937,6 +937,10 @@ static const struct umass_devdescr umass_devdescr[] = { UMASS_PROTO_SCSI | UMASS_PROTO_BBB, NO_INQUIRY_EVPD }, + {USB_VENDOR_WESTERN, USB_PRODUCT_WESTERN_MYPASSWORD, RID_WILDCARD, + UMASS_PROTO_SCSI | UMASS_PROTO_BBB, + FORCE_SHORT_INQUIRY + }, {USB_VENDOR_WINMAXGROUP, USB_PRODUCT_WINMAXGROUP_FLASH64MC, RID_WILDCARD, UMASS_PROTO_SCSI | UMASS_PROTO_BBB, NO_INQUIRY diff --git a/sys/dev/usb/usbdevs b/sys/dev/usb/usbdevs index 288750c..372bfa6 100644 --- a/sys/dev/usb/usbdevs +++ b/sys/dev/usb/usbdevs @@ -2490,6 +2490,7 @@ product WESTERN COMBO 0x0200 Firewire USB Combo product WESTERN EXTHDD 0x0400 External HDD product WESTERN HUB 0x0500 USB HUB product WESTERN MYBOOK 0x0901 MyBook External HDD +product WESTERN MYPASSWORD 0x0704 MyPassword External HDD /* Windbond Electronics */ product WINBOND UH104 0x5518 4-port USB Hub --=-65egvB1PoKNSGJJbjYrX--