Date: Tue, 28 Feb 2023 00:20:37 GMT From: Warner Losh <imp@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 873c13f9f7f0 - main - CONTRIBUTING.md: Suggest PR and Differential Revision lines Message-ID: <202302280020.31S0KbfB035769@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=873c13f9f7f0145644ba78de38ed403f0a2005df commit 873c13f9f7f0145644ba78de38ed403f0a2005df Author: Warner Losh <imp@FreeBSD.org> AuthorDate: 2023-02-28 00:19:25 +0000 Commit: Warner Losh <imp@FreeBSD.org> CommitDate: 2023-02-28 00:19:25 +0000 CONTRIBUTING.md: Suggest PR and Differential Revision lines When there's an open PR and/or a Differential Revision, people evaluating the pull request will want to look at them. Suggest that the submitter include this information to make it easier to process. Sponsored by: Netflix --- CONTRIBUTING.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 45f058dfd1d3..f5ae3e8fccc9 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -30,6 +30,8 @@ A pull request will be considered if: * Commits should include one or more `Signed-off-by:` lines with full name and email address certifying https://developercertificate.org/[Developer Certificate of Origin]. * The commits follow FreeBSD's style guide. See [Style](#Style). * The commits should not introduce trailing white space. +* If the commmit fixes a bug, please add 'PR: <bugnumber>' to the comment message. +* If there's a code review in phabricator, please include a link as a 'Differential Revision: ' line. When updating your pull request, please rebase with a forced push rather than a merge commit.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202302280020.31S0KbfB035769>