From nobody Tue Sep 9 18:42:40 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cLt3x2rcPz67HPg for ; Tue, 09 Sep 2025 18:42:53 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cLt3x0pZ2z3rpx for ; Tue, 09 Sep 2025 18:42:53 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-3e537dc30c7so4330529f8f.3 for ; Tue, 09 Sep 2025 11:42:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757443371; x=1758048171; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NWNxiKDD+u2sDYYnYMXWh5MZjooIJ0dCnpUu5XS3lI4=; b=HM54BcFB3Vj+ENhfKauqOV42T5IvLiK8LtHe4qBDisLinnxTy1364QnnW9gl6S6Iws xEnWc7x6d4OASMvGoPd66337wrZV1L6vx8bEljShLZcut2O2o7rXbWSTL7uxiYKx54JS 5615Iva7xEa5Edo+pChFNoZHf//8sfdizSZDg5TFrpnvNO/DITF7xv9BRNN8CG8sebPS 1clMT7BXz78aabMX2jgF5SFtiHuw4kC1Kfoo0q81u+KQerybsgG42138wRMYDVKxZEJ0 yCKR8QT8jCrL1MEdxhr0StexVZj2lF7G8EbL8yWJu9K48xszY/DDLIiZU0ml+rIJXmVS oMfg== X-Forwarded-Encrypted: i=1; AJvYcCWTPIF7EsxiM9dEHXx8B3HRBIFvtjk901M3l3qJo5sa3QN9N7ABziLcOzfjD+BeB6M+DLXc0ZIwrR+AG0XUXX5/VVzDeA==@freebsd.org X-Gm-Message-State: AOJu0YxtjYc1+3tY9iMADkFi2C8Qu7p+bX1PNY8gyz+4kSw6/XJQoBgA nUZTe1xnDQ/gcVKSclYZgSRaoATXCf2Zn1D6ln7aZ59GGpd5x4aRVJ7ztln8KZtTcBYSn3jc2No 2z0Tq X-Gm-Gg: ASbGncs9x3+znnqTDLZqoVvSs76skXtN+sh3dgcpBUjO14n155++3RG+5aXWCtpMPXr yod3wkwORiQMRI6iIQQydvy6LKZwOTS4K3Dpfl8Pq/Tzl2WZ6UNje6NY7BjAwOfddp3D06aIFEb x0LVJ8zuE5mhvkcLEyM1jza18alYkPkEjnWuEdYHsbSx+EUtYVLuV04+0VTBb00c4ubIr4gmwN3 /USf6znLZtpwrrUY9v41EKE30bnXAzknf5sSRNHYdChRx1G7y5Xn0aM1Yf+u4aHCwA4mnv8Sj2h ZV61z3FiXwVrwYdU0KKCeZtR0FvqPZSY/eLjJAcqO0fmFjBxRel4+XJh2n+bd/JRNTUMygO8lvs a0PM0Ny8nHCWLexim6w4GitYt90Kc/nfUepZMubK2lfQv8huYfJfVBc3GuFs= X-Google-Smtp-Source: AGHT+IEuCIrfNBZ5u1drP+TP9raKgLw8YjL5shwVpsk3vQaxWCuL0cinV7zefwZpbNEzLykXihQ4jQ== X-Received: by 2002:a05:6000:2504:b0:3d2:2989:224 with SMTP id ffacd0b85a97d-3e63736e27fmr9850088f8f.7.1757443371175; Tue, 09 Sep 2025 11:42:51 -0700 (PDT) Received: from smtpclient.apple (nat-184-7.net.cam.ac.uk. [131.111.184.7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3e75224d04dsm3587051f8f.55.2025.09.09.11.42.50 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Sep 2025 11:42:50 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\)) Subject: Re: git: 16f600dc30b7 - main - jaildesc: replace EBADF with EINVAL From: Jessica Clarke In-Reply-To: <202509091818.589II2D2005924@gitrepo.freebsd.org> Date: Tue, 9 Sep 2025 19:42:40 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <9B159FF1-8D1D-4F1D-9CED-977EB0834403@freebsd.org> References: <202509091818.589II2D2005924@gitrepo.freebsd.org> To: Jamie Gritton X-Mailer: Apple Mail (2.3826.700.81) X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4cLt3x0pZ2z3rpx On 9 Sep 2025, at 19:18, Jamie Gritton wrote: >=20 > The branch main has been updated by jamie: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D16f600dc30b7bb82429660e540da802a= 1e3f7449 >=20 > commit 16f600dc30b7bb82429660e540da802a1e3f7449 > Author: Jamie Gritton > AuthorDate: 2025-09-09 18:13:11 +0000 > Commit: Jamie Gritton > CommitDate: 2025-09-09 18:13:11 +0000 >=20 > jaildesc: replace EBADF with EINVAL >=20 > Following fd9e09cb, EBADF is not the suitable error code for a non- > jail descriptor passed to jail_set, jail_get, jail_attach_fd, and > jail_remove_fd. >=20 > Reported by: kib Will you be MFC=E2=80=99ing this fix, the error checking one and any = future fixes to the new jaildesc code? The original jaildesc commit made it in in time for stable/15 so will be part of 15.0, so either important fixes need to be MFC=E2=80=99ed to ensure we release something without = bugs or it should be reverted in stable/15 and the whole series later MFC=E2=80=99= ed once deemed ready. Especially given the discussion about file object ownership I=E2=80=99m a bit concerned that we have something in = stable/15 that has a design, rather than implementation, aspect that might be wrong, and we really don=E2=80=99t want to be shipping a broken syscall ABI if = so. Jessica