From owner-freebsd-hackers@freebsd.org  Mon Aug  3 17:11:36 2020
Return-Path: <owner-freebsd-hackers@freebsd.org>
Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 988623A1ACD
 for <freebsd-hackers@mailman.nyi.freebsd.org>;
 Mon,  3 Aug 2020 17:11:36 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4BL4DS0skPz473v;
 Mon,  3 Aug 2020 17:11:35 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from tom.home (kib@localhost [127.0.0.1])
 by kib.kiev.ua (8.16.1/8.16.1) with ESMTPS id 073HBSYt057128
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Mon, 3 Aug 2020 20:11:31 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 073HBSYt057128
Received: (from kostik@localhost)
 by tom.home (8.16.1/8.16.1/Submit) id 073HBSRi057126;
 Mon, 3 Aug 2020 20:11:28 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
 using -f
Date: Mon, 3 Aug 2020 20:11:28 +0300
From: Konstantin Belousov <kostikbel@gmail.com>
To: Steve Wills <swills@freebsd.org>
Cc: freebsd-hackers@freebsd.org
Subject: Re: SOL_LOCAL define
Message-ID: <20200803171128.GV2551@kib.kiev.ua>
References: <50992471-7f17-dcdf-949f-1b0512a9b84d@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <50992471-7f17-dcdf-949f-1b0512a9b84d@FreeBSD.org>
X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM,
 NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on tom.home
X-Rspamd-Queue-Id: 4BL4DS0skPz473v
X-Spamd-Bar: ----
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [-4.00 / 15.00];
 ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US];
 REPLY(-4.00)[]
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.33
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
 <freebsd-hackers.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers/>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Aug 2020 17:11:36 -0000

On Mon, Aug 03, 2020 at 12:19:42PM -0400, Steve Wills wrote:
> Hi,
> 
> I ran into a case where some code I was building expected SOL_LOCAL to be
> defined since LOCAL_PEERCRED was defined. See:
> 
> https://github.com/nanomsg/nng/pull/1272
> 
> for details. And looking at getpeereid.c:
> 
> https://svnweb.freebsd.org/base/head/lib/libc/gen/getpeereid.c?view=markup#l50
> 
> I see:
> 
>         error = _getsockopt(s, 0, LOCAL_PEERCRED, &xuc, &xuclen);
> 
> I wonder if something like a:
> 
> #define SOL_LOCAL 0
> 
> in sys/sys/un.h and a change to the above to:
> 
>         error = _getsockopt(s, SOL_LOCAL, LOCAL_PEERCRED, &xuc, &xuclen);
> 
> might be useful for compatibility and clarity? Any opinions?

This is something added by MacOS X 10.8 it seems.
I see no negative effects of the addition, so why not.
https://reviews.freebsd.org/D25933