From owner-svn-src-head@FreeBSD.ORG Tue Mar 2 13:30:03 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CCB501065676; Tue, 2 Mar 2010 13:30:03 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 89C698FC1C; Tue, 2 Mar 2010 13:30:03 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 251C846B0C; Tue, 2 Mar 2010 08:30:03 -0500 (EST) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPA id 5FD918A024; Tue, 2 Mar 2010 08:30:02 -0500 (EST) From: John Baldwin To: Alfred Perlstein Date: Tue, 2 Mar 2010 07:56:48 -0500 User-Agent: KMail/1.12.1 (FreeBSD/7.3-CBSD-20100217; KDE/4.3.1; amd64; ; ) References: <201003020658.o226wwB2051156@svn.freebsd.org> In-Reply-To: <201003020658.o226wwB2051156@svn.freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201003020756.48609.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Tue, 02 Mar 2010 08:30:02 -0500 (EST) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-1.5 required=4.2 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r204552 - in head/sys: conf kern net sys X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Mar 2010 13:30:04 -0000 On Tuesday 02 March 2010 1:58:58 am Alfred Perlstein wrote: > Author: alfred > Date: Tue Mar 2 06:58:58 2010 > New Revision: 204552 > URL: http://svn.freebsd.org/changeset/base/204552 > > Log: > Merge projects/enhanced_coredumps (r204346) into HEAD: > > Enhanced process coredump routines. > > This brings in the following features: > 1) Limit number of cores per process via the %I coredump formatter. > Example: > if corefilename is set to %N.%I.core AND num_cores = 3, then > if a process "rpd" cores, then the corefile will be named > "rpd.0.core", however if it cores again, then the kernel will > generate "rpd.1.core" until we hit the limit of "num_cores". > > this is useful to get several corefiles, but also prevent filling > the machine with corefiles. > > 2) Encode machine hostname in core dump name via %H. > > 3) Compress coredumps, useful for embedded platforms with limited space. > A sysctl kern.compress_user_cores is made available if turned on. > > To enable compressed coredumps, the following config options need to be set: > options COMPRESS_USER_CORES > device zlib # brings in the zlib requirements. > device gzio # brings in the kernel vnode gzip output module. > > 4) Eventhandlers are fired to indicate coredumps in progress. > > 5) The imgact sv_coredump routine has grown a flag to pass in more > state, currently this is used only for passing a flag down to compress > the coredump or not. > > Note that the gzio facility can be used for generic output of gzip'd > streams via vnodes. > > Obtained from: Juniper Networks > Reviewed by: kan > > Added: > head/sys/kern/kern_gzio.c (contents, props changed) > head/sys/net/zutil.h (contents, props changed) > Modified: > head/sys/conf/files > head/sys/conf/options > head/sys/kern/imgact_elf.c > head/sys/kern/kern_sig.c > head/sys/net/zlib.h > head/sys/sys/eventhandler.h > head/sys/sys/imgact.h > head/sys/sys/imgact_aout.h > head/sys/sys/imgact_elf.h > head/sys/sys/sysent.h > > Modified: head/sys/conf/files > ============================================================================== > --- head/sys/conf/files Tue Mar 2 06:54:15 2010 (r204551) > +++ head/sys/conf/files Tue Mar 2 06:58:58 2010 (r204552) > @@ -2053,6 +2053,7 @@ kern/kern_exec.c standard > kern/kern_exit.c standard > kern/kern_fail.c standard > kern/kern_fork.c standard > +kern/kern_gzio.c optional gzio > kern/kern_idle.c standard > kern/kern_intr.c standard > kern/kern_jail.c standard > @@ -2344,7 +2345,7 @@ net/slcompress.c optional netgraph_vjc > net/vnet.c optional vimage > net/zlib.c optional crypto | geom_uzip | ipsec | \ > mxge | netgraph_deflate | \ > - ddb_ctf > + ddb_ctf | zlib > net80211/ieee80211.c optional wlan > net80211/ieee80211_acl.c optional wlan wlan_acl > net80211/ieee80211_action.c optional wlan Did you consider just making net/zlib.c be included if 'gzio' was defined? Then you would just need to add 'device gzio'. This would appear to be more consistent with the rest of the zlib-using kernel components as they all do that rather than requiring a separate 'device zlib' line. -- John Baldwin