From owner-cvs-all Tue Dec 31 12:50:38 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CB90837B401; Tue, 31 Dec 2002 12:50:37 -0800 (PST) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 350EE43EB2; Tue, 31 Dec 2002 12:50:37 -0800 (PST) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.6/8.12.2) with ESMTP id gBVKoGmm087458; Tue, 31 Dec 2002 12:50:16 -0800 (PST) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.6/8.12.6/Submit) id gBVKn1Qm087434; Tue, 31 Dec 2002 12:49:01 -0800 (PST) Date: Tue, 31 Dec 2002 12:49:01 -0800 From: "David O'Brien" To: "M. Warner Losh" Cc: anders@hack.org, phk@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/release Makefile Message-ID: <20021231204901.GA87057@dragon.nuxi.com> Reply-To: obrien@FreeBSD.org Mail-Followup-To: David O'Brien , "M. Warner Losh" , anders@hack.org, phk@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org References: <200212311517.gBVFHOVE046201@repoman.freebsd.org> <20021231153531.GA726@hellraiser.andersa.net> <20021231175547.GA85448@dragon.nuxi.com> <20021231.141530.100232295.imp@bsdimp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20021231.141530.100232295.imp@bsdimp.com> User-Agent: Mutt/1.4i X-Operating-System: FreeBSD 5.0-RC Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, Dec 31, 2002 at 02:15:30PM -0600, M. Warner Losh wrote: > : Well, this change will probably go back in -- PHK did a 100% against the > : rules back out of my commit. I haven't seen any bug reports in > : freebsd-current or my inbox about my commit upping the the size causing > : problems. > > This is not 100% against the rules. You committed something, things > broke, phk restored the status quo while things could be resolved. > Standard operating proceedure as far as I can tell. I'd go with maybe > 10-20% against the rules for not emailing you first, but 100% > overstates things too much. If this isn't 100% against the rules then why the fck did I land in the box for doing just this the end of October?!? Things were not BROKE. "make release" built. One of many code paths seems to have a bug. Again just like happened with libfetch in October. (except I didn't get any bug report) Also can a committer back out a maintainer approved commit w/o asking the maintainer first? re@ is the maintainer of release/Makefile and my commit had their full backing. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message