From owner-freebsd-ports@FreeBSD.ORG  Fri Jul 25 17:19:42 2008
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id AAFF1106568B
	for <freebsd-ports@freebsd.org>; Fri, 25 Jul 2008 17:19:42 +0000 (UTC)
	(envelope-from kris@FreeBSD.org)
Received: from weak.local (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id E98138FC28;
	Fri, 25 Jul 2008 17:19:41 +0000 (UTC)
	(envelope-from kris@FreeBSD.org)
Message-ID: <488A0B2E.9070403@FreeBSD.org>
Date: Fri, 25 Jul 2008 19:19:42 +0200
From: Kris Kennaway <kris@FreeBSD.org>
User-Agent: Thunderbird 2.0.0.16 (Macintosh/20080707)
MIME-Version: 1.0
To: "V.Chukharev" <chukharev@mail.ru>
References: <op.ueqfl1xy0g54sc@localhost>
	<08GlBzRclM@dmeyer.dinoex.sub.org>	<op.ueumske80g54sc@localhost>
	<op.ueuwd8rs0g54sc@localhost>
In-Reply-To: <op.ueuwd8rs0g54sc@localhost>
Content-Type: text/plain; charset=KOI8-R; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Dirk Meyer <dirk.meyer@dinoex.sub.org>, freebsd-ports@freebsd.org
Subject: Re: Mk/bsd.openssl.mk optimization
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 25 Jul 2008 17:19:42 -0000

V.Chukharev wrote:
> On Fri, 25 Jul 2008 16:09:10 +0300, V.Chukharev <chukharev@mail.ru> wrote:
> 
>> On Fri, 25 Jul 2008 07:30:18 +0300, Dirk Meyer <dirk.meyer@dinoex.sub.org> wrote:
>>
>>> So you are right that make index could be otimized,
>>> but it will take much more work.
>> Totally agree on this. I tryed to make caching in bsd.subdir.mk as Kris
>> proposed, and I got also considerable speedup, but not as good as
>> with the first patch. The grep on all packages is done once per port
>> category. I miss how to pass the results to a child make...
>>
>> Anyway, I attach the new (better, but still not fully working) patch JFYI.
> 
> Well, I've found how to pass params to a child make. So the next version of the
> patch comes at the end of this post.
> 
> This patch should work well for index builds, but I have big doubts about
> all the rest. Please review and test if possible.
> 
> With the patch Mk/bsd.port.sudir.mk .include's Mk/bsd.openssl.mk, hence everywhere
> when the former is used the latter is inderectly included. This is because I did not 
> want to split the openssl staff into two parts. I put some protection.

You don't want to .include the file, just use the same make -f trick 
that I used for e.g. the python and java variable caching.

Kris