From owner-freebsd-current  Tue Sep 23 23:41:32 1997
Return-Path: <owner-freebsd-current>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.7/8.8.7) id XAA07112
          for current-outgoing; Tue, 23 Sep 1997 23:41:32 -0700 (PDT)
Received: from usr07.primenet.com (tlambert@usr07.primenet.com [206.165.6.207])
          by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id XAA07107
          for <current@FreeBSD.ORG>; Tue, 23 Sep 1997 23:41:30 -0700 (PDT)
Received: (from tlambert@localhost)
	by usr07.primenet.com (8.8.5/8.8.5) id XAA06060;
	Tue, 23 Sep 1997 23:39:41 -0700 (MST)
From: Terry Lambert <tlambert@primenet.com>
Message-Id: <199709240639.XAA06060@usr07.primenet.com>
Subject: Re: Daily SNAPshots at current.freebsd.org shut down for now.
To: kato@migmatite.eps.nagoya-u.ac.jp (KATO Takenori)
Date: Wed, 24 Sep 1997 06:39:41 +0000 (GMT)
Cc: jkh@time.cdrom.com, current@FreeBSD.ORG
In-Reply-To: <199709240358.MAA04770@gneiss.eps.nagoya-u.ac.jp> from "KATO Takenori" at Sep 24, 97 12:58:32 pm
X-Mailer: ELM [version 2.4 PL23]
Content-Type: text
Sender: owner-freebsd-current@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

> 
> > To undo the change in 1.49/1.41.2.1 of /sys/dev/vn/vn.c may hide the
> > panic.  But, I think this is NOT real fix.
> 
> I made patches for current and 2.2.  They are better than undoing.
> Should they be committed?

Aiiiiiiiieeeeeee!!!!!  The old version of the patch!!!!


This is in a for loop!

> ! 			if (vnodelocked)
					 {
> ! 				VOP_UNLOCK(vn->sc_vp);
				vnodelocked = 0;
			}

You can't leave it set to 1!!!!

You do the right thing in the -current patch:

[ ... ]

> ! 			if (vnodelocked) {
> ! 				VOP_UNLOCK(vn->sc_vp, 0, curproc);
> ! 				vnodelocked = 0;
> ! 			}


					Terry Lambert
					terry@lambert.org
---
Any opinions in this posting are my own and not those of my present
or previous employers.