From owner-freebsd-current@FreeBSD.ORG Mon Jun 7 12:01:37 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9B2241065675 for ; Mon, 7 Jun 2010 12:01:37 +0000 (UTC) (envelope-from marcelorossi@gmail.com) Received: from mail-gw0-f54.google.com (mail-gw0-f54.google.com [74.125.83.54]) by mx1.freebsd.org (Postfix) with ESMTP id 531A68FC16 for ; Mon, 7 Jun 2010 12:01:37 +0000 (UTC) Received: by gwj20 with SMTP id 20so350917gwj.13 for ; Mon, 07 Jun 2010 05:01:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=Ks4NUwoTQEbmYEipH7zxCuS1WLJHX5TtclBRqjHrawc=; b=EOKI7gzcMezALdJw9z/KadFW+NDWKru0KLhW0Fz8/BsZT35pumXX52OcjAElbHc7do keLMXLYABsFSsMsg7s0+H6L4JlSmrc/yanpUebquopVj9V/Ie161rttt+J1jCxZ9iWuJ qG7QbA9hlQGBdfGgLEFByL5JCGjYydpFSl5fU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=sWpU4Xk/GQOL6uMIKcOZwLhl/zYPqXEPnwkppopDX6N9b2czi675B6knEF8no4LWnB Jxf9iqAnuS89na0OeXzdIE8tYUvodY8AT0/5wIArbxoB78T28fa/nwqFKuSl9HQGstnc Xvd4/qep+M91HRC5aN1DRFX5jnt09IHUW8lq8= Received: by 10.229.226.211 with SMTP id ix19mr4621364qcb.127.1275912096380; Mon, 07 Jun 2010 05:01:36 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.86.71 with HTTP; Mon, 7 Jun 2010 05:01:16 -0700 (PDT) In-Reply-To: References: <201006031757.03341.hselasky@c2i.net> <201006040928.09768.hselasky@c2i.net> From: "Marcelo/Porks" Date: Mon, 7 Jun 2010 09:01:16 -0300 Message-ID: To: Hans Petter Selasky Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Garrett Cooper , freebsd-current@freebsd.org Subject: Re: Fwd: umodem (4) recognize a CDC-ACM device X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2010 12:01:37 -0000 On Fri, Jun 4, 2010 at 12:32 PM, Marcelo/Porks wro= te: > On Fri, Jun 4, 2010 at 4:28 AM, Hans Petter Selasky wr= ote: >>> On Thu, Jun 3, 2010 at 12:57 PM, Hans Petter Selasky >> wrote: >>> > Should be like this: Note the structure is called "bulk_min": >>> > >>> > =A0 =A0 =A0 =A0static const uint16_t bulk_min[USB_SPEED_MAX] =3D { >>> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0[USB_SPEED_LOW] =3D 8, >>> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0[USB_SPEED_FULL] =3D 8, >>> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0[USB_SPEED_HIGH] =3D 512, >>> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0[USB_SPEED_VARIABLE] =3D 512, >>> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0[USB_SPEED_SUPER] =3D 1024, >>> > =A0 =A0 =A0 =A0}; >>> > --HPS >> I think you also need to remove the check for LOW speed in the EHCI/OHCI= /UHCI >> controller drivers too. See usb/controller/{ehci.c,uhci.c,ohci.c} >> >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0case UE_BULK: >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0if (udev->speed !=3D USB_= SPEED_LOW) { >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0ep->metho= ds =3D &uhci_device_bulk_methods; >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0} >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0break; >> >> --HPS >> > > Hia Hans! It seems to work now or at least it was recognized. > > I'll make more tests on Monday and post the results. Hi all! Just to confirm, The patch works fine and I can use the device. Bellow is the full patch that Hans sent to me in private. Thanks again, Han= s. =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Differences ... =3D=3D=3D=3D //depot/projects/usb/src/sys/dev/usb/controller/ehci.c#53 (tex= t+ko) =3D=3D=3D=3D @@ -3792,9 +3792,7 @@ } break; case UE_BULK: - if (udev->speed !=3D USB_SPEED_LOW) { - ep->methods =3D &ehci_device_bulk_methods; - } + ep->methods =3D &ehci_device_bulk_methods; break; default: /* do nothing */ =3D=3D=3D=3D //depot/projects/usb/src/sys/dev/usb/controller/ohci.c#35 (tex= t+ko) =3D=3D=3D=3D @@ -2614,9 +2614,7 @@ } break; case UE_BULK: - if (udev->speed !=3D USB_SPEED_LOW) { - ep->methods =3D &ohci_device_bulk_methods; - } + ep->methods =3D &ohci_device_bulk_methods; break; default: /* do nothing */ =3D=3D=3D=3D //depot/projects/usb/src/sys/dev/usb/controller/uhci.c#32 (tex= t+ko) =3D=3D=3D=3D @@ -3068,9 +3068,7 @@ } break; case UE_BULK: - if (udev->speed !=3D USB_SPEED_LOW) { - ep->methods =3D &uhci_device_bulk_methods; - } + ep->methods =3D &uhci_device_bulk_methods; break; default: /* do nothing */ =3D=3D=3D=3D //depot/projects/usb/src/sys/dev/usb/usb_transfer.c#177 (text+= ko) =3D=3D=3D=3D @@ -3057,7 +3057,7 @@ }; static const uint16_t bulk_min[USB_SPEED_MAX] =3D { - [USB_SPEED_LOW] =3D 0, /* not supported */ + [USB_SPEED_LOW] =3D 8, [USB_SPEED_FULL] =3D 8, [USB_SPEED_HIGH] =3D 512, [USB_SPEED_VARIABLE] =3D 512, --=20 Marcelo Rossi "This e-mail is provided "AS IS" with no warranties, and confers no rights.= "