From owner-cvs-all Sun Dec 9 1: 5:55 2001 Delivered-To: cvs-all@freebsd.org Received: from winston.freebsd.org (adsl-64-173-15-98.dsl.sntc01.pacbell.net [64.173.15.98]) by hub.freebsd.org (Postfix) with ESMTP id 53A3A37B405; Sun, 9 Dec 2001 01:05:47 -0800 (PST) Received: from winston.freebsd.org (jkh@localhost [127.0.0.1]) by winston.freebsd.org (8.11.6/8.11.6) with ESMTP id fB9955q50955; Sun, 9 Dec 2001 01:05:25 -0800 (PST) (envelope-from jkh@winston.freebsd.org) To: Peter Wemm Cc: "Jordan K. Hubbard" , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/telnet sys_bsd.c In-Reply-To: Message from Peter Wemm of "Sat, 08 Dec 2001 16:44:55 PST." <20011209004455.33E553808@overcee.netplex.com.au> Date: Sun, 09 Dec 2001 01:05:05 -0800 Message-ID: <50951.1007888705@winston.freebsd.org> From: Jordan Hubbard Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG I read it, but I promptly punted it out of my brain cells again because I have a lot of things to remember these days and I didn't expect to ever be hacking on telnet, it's just pure random chance that I did. Now that I have swapped in Mark's instructions again, I have to wonder why nobody squealed at the time. What the hell? The idea behind this may make some sense, but the implementation does not. This is ugly as f**k! Has Mark lost his mind? - Jordan > "Jordan K. Hubbard" wrote: > > jkh 2001/12/08 13:51:34 PST > > > > Modified files: > > usr.bin/telnet sys_bsd.c > > Log: > > Don't assume that the number of fds to select on is known quantity (in > > this case 16). Use dynamic FD_SETs and calculated high-water marks > > throughout. > > Obtained from: OpenBSD and Apple's Radar database > > MFC after: 2 days > > Did you read the HEADS UP about telnet a few days ago? You've just > committed to machine-generated files, and this will get removed next time > they are regenerated.. > > Cheers, > -Peter > -- > Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au > "All of this is for nothing if we don't go to the stars" - JMS/B5 > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message