From nobody Tue Sep 9 15:58:07 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cLpPr1my1z6762B; Tue, 09 Sep 2025 15:58:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cLpPq5h0wz49HP; Tue, 09 Sep 2025 15:58:07 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1757433487; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FaIvfaS4/efcfjZ5aE/buWxFEVEzVS9z5Yet/Pkhf8Q=; b=mFoWrvSnfy9G6IUOySQ4effs6Xgl3E0Mzsqprdbrpyr0tXCo5yhc7uDiYsSLtTCes6lWwd 871t+WOKx+aBSDDG2Cx04TuPoIwT2BSa/IC4d0f4tzwW5W/1Hp5MjscPfRMn0DJzTpbSA9 13kuGqbPbkLMG+T9Xd2qAfupviJZpNQZAalZpcgOahOo6ZQOkQER6MTSFCGVr9LniV9ywL mlTdHGbiE+NDOiw2/5QFK7ADuSd3+T3wlcZifK7Kl8RzPirLfdtNyrY9xx1yF0sChPHKIn cKjxe3OkEykVrw7NeDasgVDci+YD7ECCxXO9orjfmMm2RGIlGO5qJCqG+RNmng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1757433487; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FaIvfaS4/efcfjZ5aE/buWxFEVEzVS9z5Yet/Pkhf8Q=; b=AeX+sWOI/RSuUpNAQYOzn9bxxGxWu+ZTXnzxmqUcGYNYRsRFWxiQUHeMQKllNL/Ue5ibd/ 6VCFbpiNxNqPEDZAYFq98j6LXeFaqMEND224FWnfeeMYvqfcoPYEaQojImbzLKpoVIx2X8 RsGXElQ7vGbfk3+24zWuylZUFPTD5N3GFd2NCSK1TTFoo9/MNHpkscmS8cWS6G00L/z1us GmDIePbOLlhVpWm6iy4z9cz3aPygn7Jr5Le3hg5jkAa6Msa7Z8uvrJAWeRFU7Ana3/j/dl upkwJXv1Y+9fnwxH/E7A+mI3L8gl2DOuxNhAEXzZRqGsuGrUEGD/SzdsXHsVyg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1757433487; a=rsa-sha256; cv=none; b=wwToJR/XuK/LbPwEaxVUSj/m4fHawbHx58Vza9VWeCqyWdGaMxcBfN7kdVpmdf/xYkvV3a 9K2cUL4z7FfPOp3jGQIMLTrNNs+nxgpXxuFz2VpPi4SFsZf0+cpKdN5g04b8k3xWq9oy2Q +drLFhG6ZZgfMC5xiWSVum2UisHu8a1yyR9R3PjvQ1K03yFaO8uvOhK4t4Rj1lKTpryWrE y1ADLQo5ve/amKcYjpceA0fgQDXZe9uJk6W2hSvF8alJcldCJyrCQb/uG+ljkahqYqQELs pFJmGfYZDFIdGfMCVGOSUwhySCqM+PA/c2xSPL5uzzDg6qt7Qhptwbb/wbJxFA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cLpPq5FTHzjyl; Tue, 09 Sep 2025 15:58:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 589Fw7Fq039542; Tue, 9 Sep 2025 15:58:07 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 589Fw7jd039539; Tue, 9 Sep 2025 15:58:07 GMT (envelope-from git) Date: Tue, 9 Sep 2025 15:58:07 GMT Message-Id: <202509091558.589Fw7jd039539@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Olivier Certner Subject: git: faf7e9937591 - main - 'kern.proc.groups' sysctl knob: Restore outputting the effective GID List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: faf7e99375910fadb1b409a756be5477b561a517 Auto-Submitted: auto-generated The branch main has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=faf7e99375910fadb1b409a756be5477b561a517 commit faf7e99375910fadb1b409a756be5477b561a517 Author: Olivier Certner AuthorDate: 2025-08-26 15:54:47 +0000 Commit: Olivier Certner CommitDate: 2025-09-09 15:56:50 +0000 'kern.proc.groups' sysctl knob: Restore outputting the effective GID In particular, fixes 'procstat -s' on a live system (for processes with more than 16 groups). Reviewed by: kib, emaste Fixes: be1f7435ef218b1d ("kern: start tracking cr_gid outside of cr_groups[]") MFC after: 9 days Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D52261 --- sys/kern/kern_proc.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/sys/kern/kern_proc.c b/sys/kern/kern_proc.c index c2855034fabf..6e56664d12ce 100644 --- a/sys/kern/kern_proc.c +++ b/sys/kern/kern_proc.c @@ -2944,8 +2944,11 @@ sysctl_kern_proc_groups(SYSCTL_HANDLER_ARGS) cred = crhold(p->p_ucred); PROC_UNLOCK(p); - error = SYSCTL_OUT(req, cred->cr_groups, - cred->cr_ngroups * sizeof(gid_t)); + error = SYSCTL_OUT(req, &cred->cr_gid, sizeof(gid_t)); + if (error == 0) + error = SYSCTL_OUT(req, cred->cr_groups, + cred->cr_ngroups * sizeof(gid_t)); + crfree(cred); return (error); }