From owner-cvs-src@FreeBSD.ORG Tue Oct 12 22:20:58 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C75E116A4CE; Tue, 12 Oct 2004 22:20:57 +0000 (GMT) Received: from gw.catspoiler.org (217-ip-163.nccn.net [209.79.217.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6700943D1F; Tue, 12 Oct 2004 22:20:57 +0000 (GMT) (envelope-from truckman@FreeBSD.org) Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2]) by gw.catspoiler.org (8.13.1/8.13.1) with ESMTP id i9CMKk5D073276; Tue, 12 Oct 2004 15:20:50 -0700 (PDT) (envelope-from truckman@FreeBSD.org) Message-Id: <200410122220.i9CMKk5D073276@gw.catspoiler.org> Date: Tue, 12 Oct 2004 15:20:46 -0700 (PDT) From: Don Lewis To: alfred@FreeBSD.org In-Reply-To: <200410122217.i9CMGuoY073261@gw.catspoiler.org> MIME-Version: 1.0 Content-Type: TEXT/plain; charset=us-ascii cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: jhb@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Oct 2004 22:20:58 -0000 On 12 Oct, Don Lewis wrote: > On 12 Oct, Alfred Perlstein wrote: >> I like this, my only concern is that there may be places that >> call this with locks held but with the kernel/user buffer wired >> so that it can't fault. >> >> Are you sure this isn't the case? (specifically for some sysctls) > > There are a number of sysctl handlers where I added code to wire the > buffer so that there was no danger of sleeping while a mutex is held. > Allocating a kernel buffer and doing an extra copy would be ugly. Oh, nevermind. The sysctl handlers use copyout(), not uiomove(). Doing Adding WITNESS_WARN() to uiomove() is probably a good thing.