From owner-freebsd-current@freebsd.org Tue Aug 21 17:00:01 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 050AA10789B2 for ; Tue, 21 Aug 2018 17:00:01 +0000 (UTC) (envelope-from arichardson.kde@gmail.com) Received: from mail-yb0-f175.google.com (mail-yb0-f175.google.com [209.85.213.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9B4928C38E; Tue, 21 Aug 2018 17:00:00 +0000 (UTC) (envelope-from arichardson.kde@gmail.com) Received: by mail-yb0-f175.google.com with SMTP id v13-v6so4759493ybq.12; Tue, 21 Aug 2018 10:00:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Zpa3j8g8izUToc5DlMe0Gh60LJRnT/qsjDqhQBB79Xc=; b=m3uJZQg4xFOGordRgktyz4fxsHuxF3FqJCTmD3+fJU7Tr99x3wpFVl9sWquHpLsS4o sIA7ZGlLxoTB/ZaaTGORT2ZNpXblvt6VaETWAT2QMXMzVVQsPyVeDt4tCpSkJILGyHK7 kpnBuosasEak+wK9iKogrW0us+OjhKCImXrgNhej6WDnCFjrJq013JT1CcKGiDLQWm8g jonCn/OL1RtT/WRCs+1altRyJN5dLrUZ8jo4nxhtazjZAbZYyF5XJbGtf7rAca0wkrxq 86Dy2AVltpqhypAcgw4C5YZ8NQynnPsqabJmlreQTsyGiX0iuxQUnd0YxSxPaGOv0AKp Bvug== X-Gm-Message-State: AOUpUlEVR0CxLi2MUjJZGFjn3bih1Ov2cgpVsthfcm3Os4yCv2bE5L09 6DM52ZnMCte15hLnI0wW9J5PvHBeNtqdgg== X-Google-Smtp-Source: AA+uWPxHxscCV/9QNypY/jqkb9MTNx1lpAFnR1XmHUcEpoxfhJhnMDvje9MGZVHRlKCZ5W5TdrE4JA== X-Received: by 2002:a25:c382:: with SMTP id t124-v6mr21832597ybf.130.1534860703953; Tue, 21 Aug 2018 07:11:43 -0700 (PDT) Received: from mail-yw1-f52.google.com (mail-yw1-f52.google.com. [209.85.161.52]) by smtp.gmail.com with ESMTPSA id l127-v6sm5734188ywc.5.2018.08.21.07.11.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Aug 2018 07:11:43 -0700 (PDT) Received: by mail-yw1-f52.google.com with SMTP id 14-v6so737108ywe.2; Tue, 21 Aug 2018 07:11:43 -0700 (PDT) X-Received: by 2002:a0d:e9c1:: with SMTP id s184-v6mr28316590ywe.506.1534860703372; Tue, 21 Aug 2018 07:11:43 -0700 (PDT) MIME-Version: 1.0 References: <20180820212448.571e1060@thor.intern.walstatt.dynvpn.de> <20180820220103.3ac8a3ac@thor.intern.walstatt.dynvpn.de> <6040ed15-143f-9a6d-8f37-b25a7e2d2036@FreeBSD.org> In-Reply-To: From: Alexander Richardson Date: Tue, 21 Aug 2018 15:11:32 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: buildworld failure: Do not include ${SRCTOP}/sys when building bootstrap tools To: Warner Losh Cc: jhb@freebsd.org, "O. Hartmann" , FreeBSD Current Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Aug 2018 17:00:01 -0000 In my testing 338129 fixed the issue. Seems like the problem is that bsd.crunchgen.mk iterates over all directories to do a make obj when it does the bootstrap-tools phase. On Tue, 21 Aug 2018 at 14:49, Warner Losh wrote: > > > > On Tue, Aug 21, 2018 at 12:38 AM, John Baldwin wrote: >> >> On 8/20/18 9:00 PM, O. Hartmann wrote: >> > -----BEGIN PGP SIGNED MESSAGE----- >> > Hash: SHA512 >> > >> > Am Mon, 20 Aug 2018 21:24:21 +0200 >> > "O. Hartmann" schrieb: >> > >> >> -----BEGIN PGP SIGNED MESSAGE----- >> >> Hash: SHA512 >> >> >> >> Building NanoBSD world on CURRENT r338113 fails due to: >> >> >> >> [...] >> >> cd /pool/sources/CURRENT/src/rescue/rescue/../../sbin/gbde && MK_TESTS=no >> >> UPDATE_DEPENDFILE=no _RECURSING_CRUNCH=1 >> >> MAKEOBJDIRPREFIX=/pool/nanobsd/amd64/ALERICH_amd64/pool/sources/CURRENT/src/amd64.amd64/rescue/rescue >> >> make MK_AUTO_OBJ=no DIRPRFX=rescue/rescue/gbde/ -DRESCUE CRUNCH_CFLAGS=-DRESCUE >> >> MK_AUTO_OBJ=no obj make[5]: "/pool/sources/CURRENT/src/tools/build/mk/Makefile.boot" >> >> line 18: Do not include ${SRCTOP}/sys when building bootstrap tools. Copy the header to >> >> ${WORLDTMP}/legacy in tools/build/Makefile instead. Error was caused by Makefile >> >> in /pool/sources/CURRENT/src/sbin/gbde *** [obj_crunchdir_gbde] Error code 1 >> >> >> >> make[4]: stopped in /pool/sources/CURRENT/src/rescue/rescue >> >> [...] >> >> >> >> >> >> This problem occured during today's source updates since I was able to build the NanoBSD >> >> image I intend to build yesterday ~ r338060. >> >> >> >> What is going wrong? >> > >> > It seems the problem has been introduced after r338095, since r338095 builds ok, while >> > r338096 doesn't. >> >> 338096 added this check to catch a kind of error in our Makefiles. Alex (cc'd) can >> help with figuring out what the error is. > > > Except we're not building anything, we're making obj in rescue... It looks like a false positive... > > Warner