From owner-freebsd-bugs@FreeBSD.ORG Tue Jul 19 10:20:32 2005 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1CFBD16A41C for ; Tue, 19 Jul 2005 10:20:32 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id DBA2643D45 for ; Tue, 19 Jul 2005 10:20:31 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j6JAKVJj093506 for ; Tue, 19 Jul 2005 10:20:31 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j6JAKVHc093505; Tue, 19 Jul 2005 10:20:31 GMT (envelope-from gnats) Date: Tue, 19 Jul 2005 10:20:31 GMT Message-Id: <200507191020.j6JAKVHc093505@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Roman Bogorodskiy Cc: Subject: Re: kern/83622: [ patch ] add network interfaces labeling support X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Roman Bogorodskiy List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jul 2005 10:20:32 -0000 The following reply was made to PR kern/83622; it has been noted by GNATS. From: Roman Bogorodskiy To: Brooks Davis Cc: Roman Bogorodskiy , FreeBSD-gnats-submit@freebsd.org Subject: Re: kern/83622: [ patch ] add network interfaces labeling support Date: Tue, 19 Jul 2005 14:18:53 +0400 --azLHFNyN32YCQGCU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Brooks wrote: > This seems like an intresting and useful feature. I'd like to see the > storage malloc'd instead of stuffed in the ifnet. There's no sense > in using 64 bytes in ever ifnet when I suspect most people won't ever > use this feature. It would also avoid hardcoding a limit in ifconfig > (you'll want to restrict overall size, probably to MAX_PHYS). To Well, I think 64 bytes is not a big problem (I assume nobody's using 5.x, 6.x and 7.x on hardware where few kilobytes make sense). Anyway, I'd be glad to see an example of malloc'ing storage for it. > maintain ABI compatability, the ifnet entry should be placed at the end > of struct ifnet. That's required for RELENG_6 and I'd like to keep HEAD > ABI compatable with RELENG_6 at least until 6.0-RELEASE. On the nikpick That's no problem to fix it.=20 > front, strlen returns a length, not a boolen. Any reason for skipping > to 128 and 129 in the ioctls? Updates to the ifconfig(8) and ifnet(9) > manpages will also be needed before a commit can happen. That's also not a problem. Roman Bogorodskiy --azLHFNyN32YCQGCU Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iQCVAwUBQtzTjYB0WzgdqspGAQJpfgQAjWpciVutTSChTnzf7U2YaaQu1EYpIkcD cCdsyPlOswvD1+A1JSxRzhG+b2MqWWJSJc2ZnjPZoXIbUEu0ucioyvjLGkO/a/eL FL2TvvfIZe0r+DCtxP/afe8D5yEVHDuOFAqzjIaTLYYenVqs61yLbs5tN7sKJ6rY KxbrmXmP2zw= =bPB/ -----END PGP SIGNATURE----- --azLHFNyN32YCQGCU--