Date: Sat, 02 May 2009 20:30:54 +0200 From: Christoph Mallon <christoph.mallon@gmx.de> To: Julian Elischer <julian@elischer.org> Cc: Maxim Sobolev <sobomax@freebsd.org>, FreeBSD Hackers <freebsd-hackers@freebsd.org>, Roman Divacky <rdivacky@freebsd.org>, Ed Schouten <ed@freebsd.org>, David Malone <dwmalone@maths.tcd.ie>, Warner Losh <imp@freebsd.org> Subject: Re: C99: Suggestions for style(9) Message-ID: <49FC915E.4050006@gmx.de> In-Reply-To: <49FC859B.20906@elischer.org> References: <200905021738.aa71693@walton.maths.tcd.ie> <49FC859B.20906@elischer.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Julian Elischer schrieb: > David Malone wrote: >> As I said, the point of a style guide is consistency. Changing it >> doesn't promote consistency, so there needs to be a good reason for >> the change, rather than a good reason not to change. In my opinion, >> there isn't a strong reason. Similarly for parens around return >> values - there's nothing (substantial) wrong with either rule, so >> they should probably be left as-is. > > Many of the previous changes to style(9) came from cases where > the existing rules led to programmers increasing their chances > of making errors, or people found themselves often misinterpreting > code in the same way, over and over again. Changing them to bring > them closer to someone's personal style has never been an acceptable > reason. There is a barrier to entry that any change must overcome > which is "It will decrease code consistency (by definition) so > it it worth it?" . For every proposed changed, I presented comprehensible reasons why I propose it. I never used "because I like it" as a pseudo-reason. Yes, these changes reflect my personal preferences, but they are my preferences for a reason and I try really hard to convey these reasons. > "parens on return statements is an example.. there are some posibilities > as to what one can do with this, but I really do find that the parens > are part of the style that I'd notice as inconsistent. What does this mean in one simple sentence? Should the clause be removed so they may not be added anymore? Christoph
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?49FC915E.4050006>