From owner-cvs-src@FreeBSD.ORG  Thu Jun 29 23:07:49 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9510F16A417
	for <cvs-src@FreeBSD.org>; Thu, 29 Jun 2006 23:07:49 +0000 (UTC)
	(envelope-from csjp@FreeBSD.org)
Received: from ems01.seccuris.com (ems01.seccuris.com [204.112.0.35])
	by mx1.FreeBSD.org (Postfix) with SMTP id F0E4E43E66
	for <cvs-src@FreeBSD.org>; Thu, 29 Jun 2006 23:07:43 +0000 (GMT)
	(envelope-from csjp@FreeBSD.org)
Received: (qmail 61154 invoked by uid 86); 29 Jun 2006 23:46:12 -0000
Received: from unknown (HELO ?127.0.0.1?) (204.112.0.37)
	by ems01.seccuris.com with SMTP; 29 Jun 2006 23:46:12 -0000
Message-ID: <44A45D3E.2040004@FreeBSD.org>
Date: Thu, 29 Jun 2006 18:07:42 -0500
From: "Christian S.J. Peron" <csjp@FreeBSD.org>
User-Agent: Thunderbird 1.5.0.4 (Macintosh/20060530)
MIME-Version: 1.0
To: Yar Tikhiy <yar@FreeBSD.org>
References: <200606291537.k5TFbeUg075956@repoman.freebsd.org>
In-Reply-To: <200606291537.k5TFbeUg075956@repoman.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/nfsclient bootp_subr.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Jun 2006 23:07:49 -0000

Yar Tikhiy wrote:
> yar         2006-06-29 15:37:39 UTC
>
>   FreeBSD src repository
>
>   Modified files:
>     sys/nfsclient        bootp_subr.c 
>   Log:
>   Use the elegant TAILQ_FOREACH() in place of a hand-rolled for() loop.
>   
>   Revision  Changes    Path
>   1.65      +1 -3      src/sys/nfsclient/bootp_subr.c
>
>
>   
Just as a point of curiosity, in some places, people are using for loops 
to avoid invalid pointer dereferences in the event that one of the queue 
items is removed by the code in the loop while iterating. Are you using 
TAILQ_FOREACH_SAFE() in such places if required?

-- 
Christian S.J. Peron
csjp@FreeBSD.ORG
FreeBSD Committer
FreeBSD Security Team