From owner-svn-src-head@freebsd.org Mon Jul 30 18:06:02 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5DEAC105CFFB for ; Mon, 30 Jul 2018 18:06:02 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x233.google.com (mail-it0-x233.google.com [IPv6:2607:f8b0:4001:c0b::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E43AF7D609 for ; Mon, 30 Jul 2018 18:06:01 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x233.google.com with SMTP id q20-v6so526296ith.0 for ; Mon, 30 Jul 2018 11:06:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=Yw1uxy5QurUHEZZ7GRvyFFp9GIWeok9xljozkPiZSDk=; b=JS++yqxfbMp4O630dNH9HC10IT3YceVZ8HId5UnlFuO3hYsirKUHzEz3oki+omVt3i w897Spyb1bUeMK6XhUvNFFOy424OJaJ3TIddMsEzTvyqnKYwlZG9D8xScTp6VSI3xQ9E fOXkGQgx98+l8Fxs09iQBeM6nPbGOyIi4bnymBlEijbGHQQ4w4l993nqeNU3zU/+5mE2 HXANpYr7DBOc+saGylwp07InUpeym0cQLyQfHnC4vqqFZjHtW2X3zU/cQsaPt3q+ptHv 3suqNLu4SMA4MnQHisZ14rcvLLlwROYt/1GmLwbFj8zDFbvgSh7emRfJS8e8JnBrCMOH Do7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=Yw1uxy5QurUHEZZ7GRvyFFp9GIWeok9xljozkPiZSDk=; b=hINVyzDoyaiPChzu62AgwupoobvZcDqKfw4wucbRT6foP5zTTM1XCx2969VYaRg6Bw R4pgbZOumdwVmy6a+PUOkrCqJp5pAAf1pYmBlIIsAsWCdpxjGKNgsQhV5qcRmVt3r3mL R5QJ5G9fep9GTahWwUX86Ho7kCPfdfnch8DULGiuK3uGRKMuTfqO1iSoitk9+d8DPn6Z wEVI7NNdq1DgqDdUozfEys7KyohiU8ipkqemvW2iVbY7pizxiiXFJWeX/6z37GjnD3ev JktYwrZiUZmM9nDE1v+Un46HyueZaNM1FmxUiqnF1Xql05IWGhZmQPfq7N66OKAqmEbN 9Rdw== X-Gm-Message-State: AOUpUlG3+LFCwA0rDiHhWx2oPGchiQbQ4ldhghnwZmvsHSbIxyGxYUj/ SjJbmd95FYeVJwF55N1tFaLIQVlnAejb7IRWbO4irw== X-Google-Smtp-Source: AAOMgpdTH6ttfWWvxplUSoU1CfQfYR+q9FYRpHw/EMmOWcZK8avcx6/KOpGOnhi7be0CaKD+U1x360lcwa3jv0leowM= X-Received: by 2002:a24:b211:: with SMTP id u17-v6mr318226ite.1.1532973961068; Mon, 30 Jul 2018 11:06:01 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 2002:a4f:4485:0:0:0:0:0 with HTTP; Mon, 30 Jul 2018 11:06:00 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: References: <201807301740.w6UHeRM0077138@repo.freebsd.org> <20180730175923.vtha72pcvzilsspu@mutt-hbsd> From: Warner Losh Date: Mon, 30 Jul 2018 12:06:00 -0600 X-Google-Sender-Auth: ls9kCj280gVlB4QoxjjFvhBF9GQ Message-ID: Subject: Re: svn commit: r336919 - head/sys/dev/efidev To: Shawn Webb Cc: Kyle Evans , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jul 2018 18:06:02 -0000 I take that back... efi.rt.disabled matches the newbus usage... Warner On Mon, Jul 30, 2018 at 12:01 PM, Warner Losh wrote: > It would be a good idea to make it like the other tuneables. > > efi.rt.enabled=0 would be the pattern. > > Warner > > On Mon, Jul 30, 2018 at 11:59 AM, Shawn Webb > wrote: > >> On Mon, Jul 30, 2018 at 05:40:27PM +0000, Kyle Evans wrote: >> > Author: kevans >> > Date: Mon Jul 30 17:40:27 2018 >> > New Revision: 336919 >> > URL: https://svnweb.freebsd.org/changeset/base/336919 >> > >> > Log: >> > efirt: Add tunable to allow disabling EFI Runtime Services >> > >> > Leading up to enabling EFIRT in GENERIC, allow runtime services to be >> > disabled with a new tunable: efi.rt_disabled. This makes it so that >> EFIRT >> > can be disabled easily in case we run into some buggy UEFI >> implementation >> > and fail to boot. >> > >> > Discussed with: imp, kib >> > MFC after: 1 week >> > >> > Modified: >> > head/sys/dev/efidev/efirt.c >> > >> > Modified: head/sys/dev/efidev/efirt.c >> > ============================================================ >> ================== >> > --- head/sys/dev/efidev/efirt.c Mon Jul 30 17:03:15 2018 >> (r336918) >> > +++ head/sys/dev/efidev/efirt.c Mon Jul 30 17:40:27 2018 >> (r336919) >> > @@ -133,7 +133,12 @@ efi_init(void) >> > struct efi_md *map; >> > caddr_t kmdp; >> > size_t efisz; >> > + int rt_disabled; >> > >> > + rt_disabled = 0; >> > + TUNABLE_INT_FETCH("efi.rt_disabled", &rt_disabled); >> >> Would it be a good idea to document this tunable in loader(8)? >> >> Thanks, >> >> -- >> Shawn Webb >> Cofounder and Security Engineer >> HardenedBSD >> >> Tor-ified Signal: +1 443-546-8752 >> Tor+XMPP+OTR: lattera@is.a.hacker.sx >> GPG Key ID: 0x6A84658F52456EEE >> GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE >> > >