From owner-cvs-src@FreeBSD.ORG Thu May 25 15:19:47 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B849616A5C0; Thu, 25 May 2006 15:19:47 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1B82F43D53; Thu, 25 May 2006 15:19:44 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [10.10.3.185] ([69.15.205.254]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id k4PFJarT028622; Thu, 25 May 2006 09:19:42 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <4475CB00.30808@samsco.org> Date: Thu, 25 May 2006 09:19:28 -0600 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.12) Gecko/20060206 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Gleb Smirnoff References: <200605241726.k4OHQG59037586@repoman.freebsd.org> <20060525111035.GI27819@FreeBSD.org> In-Reply-To: <20060525111035.GI27819@FreeBSD.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=0.0 required=3.8 tests=none autolearn=failed version=3.1.1 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Warner Losh , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/pccbb pccbb.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 May 2006 15:19:55 -0000 Gleb Smirnoff wrote: > On Wed, May 24, 2006 at 05:26:16PM +0000, Warner Losh wrote: > W> imp 2006-05-24 17:26:16 UTC > W> > W> FreeBSD src repository > W> > W> Modified files: > W> sys/dev/pccbb pccbb.c > W> Log: > W> Suspend the children before we turn off card events in hardware. This > W> was done, I believe, to work around some cards having issues in the > W> suspend case. I think that this helped my Sony VAIO TS505 work better > W> when it had certain wireless cards in it and I did a apm -z. I've not > ^^^^^^^ > W> tested suspend/resume on other laptops in a long time, so I hope this > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > W> doesn't cause greif. Please let me know if it does. > ^^^^^^^^^^^^^^^^^^^ > > Is this a joke, that I can't understand? :( > > This file has broken APM suspend since revision 1.122, which was made > almost a year ago. I've told that several times, and I still hope that > this will be fixed before RELENG_7. The problem is not in suspending > children, since suspend is broken w/o any cards in slot. The problem is > in DELAY -> tsleep() conversion. The latter is not working, when > system is suspending. > Maybe it would help if Warner published patches and called for testers before committing stuff like this? Scott