From owner-freebsd-current@FreeBSD.ORG Thu Jul 3 11:39:47 2008 Return-Path: Delivered-To: current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2BD2D10656A9 for ; Thu, 3 Jul 2008 11:39:47 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.freebsd.org (Postfix) with ESMTP id F293C8FC1E for ; Thu, 3 Jul 2008 11:39:46 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 6337746BC3 for ; Thu, 3 Jul 2008 07:39:46 -0400 (EDT) Date: Thu, 3 Jul 2008 12:39:46 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: current@FreeBSD.org Message-ID: <20080703123851.G31251@fledge.watson.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Subject: cvs commit: src/sys/netinet6 frag6.c ip6_forward.c ip6_input.c (fwd) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jul 2008 11:39:47 -0000 FYI, there was a brief window between a commit I made last night and a commit I made this morning where kernels with INVARIANTS might/would panic in the IPv6 input routine. Not sure how I missed this, but I did, so apologies in advance if you run into it! The below commit corrects that problem. Robert N M Watson Computer Laboratory University of Cambridge ---------- Forwarded message ---------- Date: Thu, 3 Jul 2008 10:55:13 +0000 (UTC) From: Robert Watson To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/netinet6 frag6.c ip6_forward.c ip6_input.c rwatson 2008-07-03 10:55:13 UTC FreeBSD src repository Modified files: sys/netinet6 frag6.c ip6_forward.c ip6_input.c Log: SVN rev 180214 on 2008-07-03 10:55:13Z by rwatson Remove GIANT_REQUIRED from IPv6 input, forward, and frag6 code. The frag6 code is believed to be MPSAFE, and leaving aside the IPv6 route cache in forwarding, Giant appears not to adequately synchronize the data structures in the input or forwarding paths. Revision Changes Path 1.36 +0 -4 src/sys/netinet6/frag6.c 1.42 +1 -1 src/sys/netinet6/ip6_forward.c 1.100 +0 -2 src/sys/netinet6/ip6_input.c