From owner-svn-src-projects@FreeBSD.ORG  Wed Jul  8 18:24:50 2009
Return-Path: <owner-svn-src-projects@FreeBSD.ORG>
Delivered-To: svn-src-projects@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 61E801065672;
	Wed,  8 Jul 2009 18:24:50 +0000 (UTC)
	(envelope-from brde@optusnet.com.au)
Received: from mail04.syd.optusnet.com.au (mail04.syd.optusnet.com.au
	[211.29.132.185])
	by mx1.freebsd.org (Postfix) with ESMTP id D8BDA8FC13;
	Wed,  8 Jul 2009 18:24:49 +0000 (UTC)
	(envelope-from brde@optusnet.com.au)
Received: from c122-107-120-90.carlnfd1.nsw.optusnet.com.au
	(c122-107-120-90.carlnfd1.nsw.optusnet.com.au [122.107.120.90])
	by mail04.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id
	n68IOkrW027395
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Thu, 9 Jul 2009 04:24:47 +1000
Date: Thu, 9 Jul 2009 04:24:46 +1000 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@delplex.bde.org
To: Rui Paulo <rpaulo@freebsd.org>
In-Reply-To: <200907081526.n68FQYDb055185@svn.freebsd.org>
Message-ID: <20090709041145.G46111@delplex.bde.org>
References: <200907081526.n68FQYDb055185@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org
Subject: Re: svn commit: r195460 - projects/mesh11s/sys/net80211
X-BeenThere: svn-src-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the src &quot; projects&quot;
	tree" <svn-src-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-projects>, 
	<mailto:svn-src-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-projects>
List-Post: <mailto:svn-src-projects@freebsd.org>
List-Help: <mailto:svn-src-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-projects>, 
	<mailto:svn-src-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Jul 2009 18:24:50 -0000

On Wed, 8 Jul 2009, Rui Paulo wrote:

> Log:
>  Remove some spurious __packed attributes.

Are they spurious?  All uses of __packed are wrong, but they might still
help work around ABI bugs.

> Modified:
>  projects/mesh11s/sys/net80211/ieee80211_mesh.h
>
> Modified: projects/mesh11s/sys/net80211/ieee80211_mesh.h
> ==============================================================================
> --- projects/mesh11s/sys/net80211/ieee80211_mesh.h	Wed Jul  8 15:25:27 2009	(r195459)
> +++ projects/mesh11s/sys/net80211/ieee80211_mesh.h	Wed Jul  8 15:26:34 2009	(r195460)
> @@ -46,7 +46,7 @@ struct ieee80211_meshconf_ie {
> 	uint8_t		conf_authid[4];	/* Auth. Protocol ID */
> 	uint8_t		conf_form;	/* Formation Information */
> 	uint8_t		conf_cap;
> -} __packed;
> +};

Broken ABIs (e.g., arm?) may add padding at the end of structs, so it
doesn't help for all members of a struct to have type uint8_t.  I think
arm always pads to make the size a multiple of 4.  The natural size of
the above struct is 6, so it seems to need __packed.

Bruce