From owner-freebsd-bugs@FreeBSD.ORG  Sun Jan 13 08:20:02 2008
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E33BE16A41B
	for <freebsd-bugs@hub.freebsd.org>;
	Sun, 13 Jan 2008 08:20:02 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 0ACF913C457
	for <freebsd-bugs@hub.freebsd.org>;
	Sun, 13 Jan 2008 08:20:03 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m0D8K2XF090386
	for <freebsd-bugs@freefall.freebsd.org>; Sun, 13 Jan 2008 08:20:02 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m0D8K2gG090385;
	Sun, 13 Jan 2008 08:20:02 GMT (envelope-from gnats)
Date: Sun, 13 Jan 2008 08:20:02 GMT
Message-Id: <200801130820.m0D8K2gG090385@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Diomidis Spinellis <dds@aueb.gr>
Cc: 
Subject: Re: bin/119614: regression tests for tr(1)
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Diomidis Spinellis <dds@aueb.gr>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 13 Jan 2008 08:20:03 -0000

The following reply was made to PR bin/119614; it has been noted by GNATS.

From: Diomidis Spinellis <dds@aueb.gr>
To: Giorgos Keramidas <keramida@FreeBSD.ORG>
Cc: David Schultz <das@FreeBSD.ORG>, FreeBSD-gnats-submit@FreeBSD.ORG,
        Diomidis Spinellis <dds@FreeBSD.ORG>
Subject: Re: bin/119614: regression tests for tr(1)
Date: Sun, 13 Jan 2008 09:36:41 +0200

 Giorgos Keramidas wrote:
 > On 2008-01-12 22:28, David Schultz <das@FreeBSD.ORG> wrote:
 >> But I'd say commit whatever tests you have, so the next time we find a
 >> bug, it will be a one-line change for someone to add a regression test
 >> for it.
 > 
 > Thanks.  I'll wait a bit for Diomidis to see the PR too, in case he
 > wants to add/change something.  Then in 1-2 days I'll commit the current
 > patch.
 
 Great!  As David commented the most important thing is to have a 
 regression test and a place where more tests can be added in the future. 
   So go ahead and commit it.
 
 You might want to add tests for the [#*n] and the [=char=] notations.
 
 Also, verify that your tests interact gracefully with Perl's 
 Test::Harness prove(1) command.
 
 Diomidis Spinellis - http://www.spinellis.gr