From owner-cvs-all Wed Feb 21 1:43:46 2001 Delivered-To: cvs-all@freebsd.org Received: from ringworld.nanolink.com (ringworld.nanolink.com [195.24.48.189]) by hub.freebsd.org (Postfix) with SMTP id 3BECE37B503 for ; Wed, 21 Feb 2001 01:43:38 -0800 (PST) (envelope-from roam@orbitel.bg) Received: (qmail 70451 invoked by uid 1000); 21 Feb 2001 09:41:44 -0000 Date: Wed, 21 Feb 2001 11:41:43 +0200 From: Peter Pentchev To: Jesper Skriver Cc: Ruslan Ermilov , Jonathan Lemon , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet ip_input.c Message-ID: <20010221114143.G12746@ringworld.oblivion.bg> Mail-Followup-To: Jesper Skriver , Ruslan Ermilov , Jonathan Lemon , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org References: <200102202131.f1KLVmD90813@freefall.freebsd.org> <20010221105306.D32098@sunbay.com> <20010221103925.G93678@skriver.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010221103925.G93678@skriver.dk>; from jesper@skriver.dk on Wed, Feb 21, 2001 at 10:39:25AM +0100 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Wed, Feb 21, 2001 at 10:39:25AM +0100, Jesper Skriver wrote: > On Wed, Feb 21, 2001 at 10:53:06AM +0200, Ruslan Ermilov wrote: > > On Tue, Feb 20, 2001 at 01:31:48PM -0800, Jesper Skriver wrote: > > > jesper 2001/02/20 13:31:48 PST > > > > > > Modified files: > > > sys/netinet ip_input.c > > > Log: > > > Send a ICMP unreachable instead of dropping the packet silent, if we > > > receive a packet not for us, and forwarding disabled. > > > > > > PR: kern/24512 > > > Reviewed by: jlemon > > > Approved by: jlemon > > > > This violates Host Requirements RFC 1122. In section 3.2.1.3, we read: > > Oups, what about - even if it violates the rfc, it's quite usefull in > some corner cases - it's something we use locally here, so I suggest > leaving it in, but disabled by default, and with the warning, ok ? just a minor nit.. [snip] > - 0, "Send ICMP unreach when packet not for us rx, and forwarding disabled"); > + 0, "Send ICMP unreach when packet not for us rx, and forwarding disabled, note violate rfc1122 section 3.2.1.3"); "..note that this violates.." > + * > + * Note: violate rfc1122 section 3.2.1.3, therefor disabled > + * by default. "Note: this violates .. therefore it is disabled.." G'luck, Peter -- Thit sentence is not self-referential because "thit" is not a word. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message