From owner-freebsd-java@FreeBSD.ORG  Fri May 28 12:26:52 2004
Return-Path: <owner-freebsd-java@FreeBSD.ORG>
Delivered-To: freebsd-java@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 57B5716A4CF; Fri, 28 May 2004 12:26:52 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 5005843D49; Fri, 28 May 2004 12:26:52 -0700 (PDT)
	(envelope-from linimon@FreeBSD.org)
Received: from freefall.freebsd.org (linimon@localhost [127.0.0.1])
	i4SJQopp004571;	Fri, 28 May 2004 12:26:50 -0700 (PDT)
	(envelope-from linimon@freefall.freebsd.org)
Received: (from linimon@localhost)
	by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i4SJQoaf004567;
	Fri, 28 May 2004 12:26:50 -0700 (PDT)
	(envelope-from linimon)
Date: Fri, 28 May 2004 12:26:50 -0700 (PDT)
From: Mark Linimon <linimon@FreeBSD.org>
Message-Id: <200405281926.i4SJQoaf004567@freefall.freebsd.org>
To: linimon@FreeBSD.org, freebsd-java@FreeBSD.org,
	portmgr@FreeBSD.org
Subject: Re: ports/66342: [PATCH] fix ECHO_MSG breakage in java ports
X-BeenThere: freebsd-java@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Porting Java to FreeBSD <freebsd-java.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-java>,
	<mailto:freebsd-java-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-java>
List-Post: <mailto:freebsd-java@freebsd.org>
List-Help: <mailto:freebsd-java-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-java>,
	<mailto:freebsd-java-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 28 May 2004 19:26:52 -0000

Synopsis: [PATCH] fix ECHO_MSG breakage in java ports

Responsible-Changed-From-To: freebsd-java->portmgr
Responsible-Changed-By: linimon
Responsible-Changed-When: Fri May 28 12:21:12 PDT 2004
Responsible-Changed-Why: 
Actually, this problem is generic to any port that wants to set
a multiline IGNORE message -- and these are almost all ports
that need to be fetched manually.  So this is really something
that needs to be fixed in bsd.port.mk.

The patch below attempts to be the dullest solution to the
problem, but I do not know if/how it will affect FreshPorts.
I have included the output from java/jmf if this patch is used.

Kris has indicated that he wants to rethink the IGNORE/NO_PACKAGE
strategy, so he is the obvious one to look at either this
short-term hack or a "real" solution.

Index: bsd.port.mk
===================================================================
RCS file: /home/FreeBSD/pcvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.488
diff -u -r1.488 bsd.port.mk
--- bsd.port.mk	19 Apr 2004 23:39:52 -0000	1.488
+++ bsd.port.mk	28 May 2004 19:16:26 -0000
@@ -2577,7 +2595,7 @@
 .if defined(IGNORE_SILENT)
 IGNORECMD=	${DO_NADA}
 .else
-IGNORECMD=	${ECHO_MSG} "===>  ${PKGNAME} ${IGNORE}."
+IGNORECMD=	${PRINTF} "===>  ${PKGNAME} ${IGNORE}."
 .endif
 
 .for target in check-sanity fetch checksum extract patch configure all build install reinstall package

-------

the result:

$ make install
===>  jmf-2.1.1e :
 Because of licensing restrictions, you must fetch the source distribution
 manually.  Please access:
 http://java.sun.com/products/java-media/jmf/2.1.1/download.html
 with a web browser and follow the "Download JMF 2.1.1e" link
 Select download format: cross-platform format
 Please place this file in /home/pcvs/ports/distfiles.
.$

not optimal, but not dreadful.

http://www.freebsd.org/cgi/query-pr.cgi?pr=66342