From owner-cvs-all  Wed May  9 11:22:46 2001
Delivered-To: cvs-all@freebsd.org
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP
	id B9E7037B422; Wed,  9 May 2001 11:22:42 -0700 (PDT)
	(envelope-from wpaul@FreeBSD.org)
Received: (from wpaul@localhost)
	by freefall.freebsd.org (8.11.1/8.11.1) id f49IMgL26127;
	Wed, 9 May 2001 11:22:42 -0700 (PDT)
	(envelope-from wpaul)
Message-Id: <200105091822.f49IMgL26127@freefall.freebsd.org>
From: Bill Paul <wpaul@FreeBSD.org>
Date: Wed, 9 May 2001 11:22:42 -0700 (PDT)
To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: cvs commit: src/sys/pci if_sk.c
X-FreeBSD-CVS-Branch: HEAD
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

wpaul       2001/05/09 11:22:42 PDT

  Modified files:
    sys/pci              if_sk.c 
  Log:
  The sk driver developed a bug when the multicast code was changed to
  use TAILQ macros. The sk_attach_xmac() routine calls sk_init_xmac()
  before doing the transceiver probe, but *before* ether_ifattach()
  is called. This causes sk_init_xmac() to call sk_setmulti(), which
  tries to do a TAILQ_FOREACH(), which it can't do because ether_ifattach()
  hasn't done a TAILQ_INIT() yet. This causes a NULL pointer dereference
  and panic in sk_setmulti() at driver load/initialization time.
  
  Fixed by calling ether_ifattach() before the MII probe.
  
  The code in RELENG_4 still uses the old way of enumerating the
  multicast list and doesn't have this problem. Yet.
  
  Revision  Changes    Path
  1.42      +9 -8      src/sys/pci/if_sk.c


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message