From owner-freebsd-mips@FreeBSD.ORG  Sun Mar 18 07:42:10 2012
Return-Path: <owner-freebsd-mips@FreeBSD.ORG>
Delivered-To: freebsd-mips@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 14146106564A
	for <freebsd-mips@freebsd.org>; Sun, 18 Mar 2012 07:42:10 +0000 (UTC)
	(envelope-from adrian.chadd@gmail.com)
Received: from mail-pz0-f54.google.com (mail-pz0-f54.google.com
	[209.85.210.54])
	by mx1.freebsd.org (Postfix) with ESMTP id E02FD8FC08
	for <freebsd-mips@freebsd.org>; Sun, 18 Mar 2012 07:42:09 +0000 (UTC)
Received: by dald2 with SMTP id d2so8890945dal.13
	for <freebsd-mips@freebsd.org>; Sun, 18 Mar 2012 00:42:09 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:sender:in-reply-to:references:date
	:x-google-sender-auth:message-id:subject:from:to:cc:content-type;
	bh=I1Vs7UE54jPmXU8U+tn0AUJT6r14AeYfoGydQr3kTAs=;
	b=kNbmVJivLPuQnsbpokxR6t93YNWOYtcMKGqO3PR58KRZQihU9BA5yP+zhWCMqtZeQf
	Cs6vouVtUl7NaVrQRGrm7KjEnGhxIz9uYUYT0qvKx4Mn41TBnGBcLrKmJnVk3otlkW/o
	qSNThExEXHcPCyBwlqwxakq9x0k/V3dzeTnLFv6dptBFoJWkv2xxZMYZdTcExLB7wzpp
	YVZggm86oowl3RiPCkIGOZWewvVa44SgWvCc13qvjVloJ41p/ttEnvDt6r1h1Q+CCzeP
	Jb0oBL0WGESF4Kj9C3r17wH1JpAseG9MIJecvhr4akiSyBKc3E1of0NnN9gZZ4LsBOYA
	kM2A==
MIME-Version: 1.0
Received: by 10.68.191.168 with SMTP id gz8mr29253989pbc.37.1332056529408;
	Sun, 18 Mar 2012 00:42:09 -0700 (PDT)
Sender: adrian.chadd@gmail.com
Received: by 10.143.33.5 with HTTP; Sun, 18 Mar 2012 00:42:09 -0700 (PDT)
In-Reply-To: <A9B53A21-71EF-43A1-9354-A1F17013C496@bluezbox.com>
References: <A9B53A21-71EF-43A1-9354-A1F17013C496@bluezbox.com>
Date: Sun, 18 Mar 2012 00:42:09 -0700
X-Google-Sender-Auth: kLuVcAyxLSS85begEs8YsiJSzhM
Message-ID: <CAJ-Vmo=mAjPCoDb+pWTZEo3JXuqGh+jbAE=W-bZ7=vOt4xLjWA@mail.gmail.com>
From: Adrian Chadd <adrian@freebsd.org>
To: Oleksandr Tymoshenko <gonzo@bluezbox.com>
Content-Type: text/plain; charset=ISO-8859-1
Cc: freebsd-mips@freebsd.org
Subject: Re: hwpmc(4) MIPS code refactoring / bugfixes
X-BeenThere: freebsd-mips@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting FreeBSD to MIPS <freebsd-mips.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-mips>,
	<mailto:freebsd-mips-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-mips>
List-Post: <mailto:freebsd-mips@freebsd.org>
List-Help: <mailto:freebsd-mips-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-mips>,
	<mailto:freebsd-mips-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 18 Mar 2012 07:42:10 -0000

Hi!

On 18 March 2012 00:24, Oleksandr Tymoshenko <gonzo@bluezbox.com> wrote:
> Hello,
>
> Proposed patch fixes some issues in hwpmc(4) and makes adding support
> for more MIPS CPUs much easier. I'd appreciate reviews and any
> feedback.
>
> http://people.freebsd.org/~gonzo/mips/pmc-2.diff

Thanks for this!

Some of this stuff looks like it can be committed as small, standalone fixes:

* pmc_syscall_args is standalone, right?
* changing the MIPS rtld is also a separate commit
* same deal with pmcstat_log.c? But this would also impact non-MIPS
platforms so we'd have to test those?

I like fixing up the generic MIPS PMC code to be generic, as I'd like
to eventually reuse it for mips74k support.

Other than that, great work! I'm so glad this has made such great
progress in the past week.



Adrian