From nobody Mon Apr 28 15:45:01 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZmSSZ6YWhz5vVWj; Mon, 28 Apr 2025 15:45:02 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZmSSZ5lxwz4QQV; Mon, 28 Apr 2025 15:45:02 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1745855102; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CK2plDc2JaAw45cevpPj+hXo7jDUZWro1otks1jyfi8=; b=wOI3+sP6gtmu15bmUsd7PmjiIOxsLfPym/RroQSiCJmqKBN4a4ex5/8V7y9aGMiRD6/OtF g06ZlVxB7FrYRb9AwLu0n7IGJLyETmGCwNVgqvKUSgcRE2jYtqbZFMc/mwFZLuoah0okSa q5GZmhN+o1og2kcee3YKKgoHst0NZclvBAm9WNLls6DZPkbFSm64qwzm+t7F2LG5gGibSO hotK5H8kRz8VDQCSfP+86LSKg7R3qkuRhtoo0wRJ4F2BWwJpr205ZBOImudvH9HWSMJXFU BE4RQEIAu7w02OF1r0Xh9HrWUFXOjZcXGyE9t0ZlttsHDvC7jDtcy4pDa63ZdQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1745855102; a=rsa-sha256; cv=none; b=LWvNGevJ/Li8/oX8M0NvJ7EHV1K3DnriGNw2/yBfygd3YzQZs/wmfdWcppjaj6OIZLxWJW 644Azc7a2qS4BdMCF1laygsp+0u05Xr/x5yhReJfsZnedGRRjCqqV7YlwH9XEVR6DnW61T OkQFfD+IDtpEkppsftr0eH3f8Xv6OJb5JkXKgdt6icAKmFbDP4Z/NvtZljHzsRh5KZ7dBj k//Vk8EUqTmi0WAuVN3CKKW4tvtREabbXTKDuZ9iurooAw0xI/69Va6shKU6TIhfdYRP4T /I1bS/N8Wd+PtUWpjhnbFfJ0i1F9kT3OLuJuzpeasrwvEsK7WYsjIBtlcMq4aQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1745855102; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CK2plDc2JaAw45cevpPj+hXo7jDUZWro1otks1jyfi8=; b=ZftJNXR+QVYc4tGRe7glJUAYmINrfuL5ZItVNjZD/JylT1PK+1hugYJoofj2cyNSS+YzwI pg0fIuSPdwOFcX2xYTjBIgXTmIkwk2RogeDjZmjZ5CesXR6xgyTvfYCqIX6JpEv5n4/EG7 8CltMjviEqdLRwX+A8QrjvZoNqi0FdgddeyqzWr0PrpGmFR+JFD5eC78UmStuZp+Kxy6ut 6euFRMveBTn7bTQmjWiIU/YqAnbbE9z4e0gZr6Ii8+p1TtkqyqwZPpQZnlrm9RPWiPzx0X Q+/CJYfSs4rWY5Ft/bV3sEaVXU/PdUnChCiKyHyj+P31f3BrCRSwWF2dZD4MNw== Received: from [IPV6:2601:5c0:4200:b830:a502:8833:7847:ef8] (unknown [IPv6:2601:5c0:4200:b830:a502:8833:7847:ef8]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4ZmSSZ3XYVz17JX; Mon, 28 Apr 2025 15:45:02 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <5a261558-6c1f-4e29-a71b-fd3cb6bd1e70@FreeBSD.org> Date: Mon, 28 Apr 2025 11:45:01 -0400 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: a098111a28ed - main - secure: Add ssh-sk-client to all consumers of libssh Content-Language: en-US To: Jessica Clarke , Shawn Webb Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202504220207.53M27okn077850@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 4/24/25 18:56, Jessica Clarke wrote: > On 24 Apr 2025, at 23:45, Shawn Webb wrote: >> On Tue, Apr 22, 2025 at 02:07:50AM +0000, John Baldwin wrote: >>> The branch main has been updated by jhb: >>> >>> URL: https://cgit.FreeBSD.org/src/commit/?id=a098111a28ed59e1ab1101ad09913f0235ebd28f >>> >>> commit a098111a28ed59e1ab1101ad09913f0235ebd28f >>> Author: John Baldwin >>> AuthorDate: 2025-04-22 02:05:28 +0000 >>> Commit: John Baldwin >>> CommitDate: 2025-04-22 02:05:28 +0000 >>> >>> secure: Add ssh-sk-client to all consumers of libssh >>> >>> These all failed to link with ld.bfd used by GCC due to >>> Fssh_sshsk_sign being an unresolved symbol. >>> >>> Fixes: 65d8491719bb ("secure: Adapt Makefile to ssh-sk-client everywhere") >> >> Hey John, >> >> I'm getting the following error from the RTLD when the rc scripts >> start sshd: >> >> ==== BEGIN LOG ==== >> ld-elf.so.1: /usr/lib/libprivatessh.so.5: Undefined symbol "Fssh_sshsk_sign >> ==== END LOG ==== >> >> This is on HardenedBSD 15-CURRENT/amd64. I'll try to reproduce next >> week with vanilla FreeBSD, unless someone else beats me to it. This error seems to be that you've built the new libssh but have an old sshd, etc. > I don’t understand how this is meant to work. sshsk_sign is used by > sshkey.c, which is in libssh, so why are we putting the definition of > sshsk_sign (namespaced) in each and every program? Yeah, it's not clear to me that the original commit is correct. It makes libssh no longer be self-contained. -- John Baldwin