From owner-freebsd-bugs@FreeBSD.ORG  Thu Dec 18 09:38:05 2003
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A661E16A4CE
	for <freebsd-bugs@hub.freebsd.org>;
	Thu, 18 Dec 2003 09:38:05 -0800 (PST)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 695BC43E51
	for <freebsd-bugs@hub.freebsd.org>;
	Thu, 18 Dec 2003 09:30:53 -0800 (PST)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	hBIHUMFR051605	for <freebsd-bugs@freefall.freebsd.org>;
	Thu, 18 Dec 2003 09:30:22 -0800 (PST)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.10/8.12.10/Submit) id hBIHUMSl051604;
	Thu, 18 Dec 2003 09:30:22 -0800 (PST)
	(envelope-from gnats)
Date: Thu, 18 Dec 2003 09:30:22 -0800 (PST)
Message-Id: <200312181730.hBIHUMSl051604@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Yar Tikhiy <yar@FreeBSD.ORG>
Subject: Re: kern/47920: if ng_pppoe switches to nonstandard mode it stays
	in it forever
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Yar Tikhiy <yar@FreeBSD.ORG>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Dec 2003 17:38:05 -0000

The following reply was made to PR kern/47920; it has been noted by GNATS.

From: Yar Tikhiy <yar@FreeBSD.ORG>
To: Gleb Smirnoff <glebius@cell.sick.ru>
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: kern/47920: if ng_pppoe switches to nonstandard mode it stays in it forever
Date: Thu, 18 Dec 2003 20:22:04 +0300

 Mime-Version: 1.0
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 In-Reply-To: <20031218100848.GA67923@cell.sick.ru>
 User-Agent: Mutt/1.5.3i
 
 On Thu, Dec 18, 2003 at 01:08:48PM +0300, Gleb Smirnoff wrote:
 > On Wed, Dec 17, 2003 at 08:42:34PM +0300, Yar Tikhiy wrote:
 > Y> Would you mind testing the below version of your patch, revised.
 > Y> Please pay attention to its points:
 > Y> a) sanity check values passed through sysctl;
 > Y> b) avoid double setting nonstandard mode;
 > Y> c) format source according to style(9);
 > Y> d) initialize pppoe_mode for clarity since it's no longer
 > Y>    just a boolean trigger.
 > 
 > I have tested it on STABLE. It works OK. I have also asked PR's
 > originator to test it.
 
 Thanks!  By the way, don't you think that the default value for the
 sysctl controlling pppoe mode should be -1?  I've just read this PR
 once more and realized that the current default of 0 is *really dangerous*
 because a spurious non-standard PPPoE frame can plague an entire network!
 
 -- 
 Yar