From nobody Mon Dec 15 13:30:15 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dVLXS1YrSz6Kj1j for ; Mon, 15 Dec 2025 13:30:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dVLXR6wbNz4B1J for ; Mon, 15 Dec 2025 13:30:15 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1765805416; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RSAI+5LFSjw9SdiGHmLfvyAuX59jGxcoR14bXALLxsE=; b=As13C5LBKVexXcoaWWxrCx80XvAbQTMQ6SfJ9xeA/vvvj/JksN0ZUIixURuzHeiltZGofD Gj4abW+AVQuEIP8Kpci1IA7wqVPsnuOgzIuaWq9VIR4+9tWHz4As7Y6bzwCbczhSWj8dWq xwTKgh2advCry9tF/FYiyAupLZq9xJR2K5rhd3w6GNPPo4V7c1jy74jsY0KtkNPuwAGSqn r9z8MNR8I2C/venPwVzD0QwG8Qi2KFi9msU2W1EhwdKEy4b4ba2fE94J6b7OvMKtLH+E+3 FRjEKxdujeZM4GR1Pmd7crfhcmSX+ctXoXVGs5zctmO1e/XGZbTFcIQmAhIvOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1765805416; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RSAI+5LFSjw9SdiGHmLfvyAuX59jGxcoR14bXALLxsE=; b=KrtwlIxKEgclB+lrBBY49+3uJ0TNBS2jlAgM69tWTH/twCKkySOXze7ro63cpHKnuA1N1K vH9f3HD4mNaXePU5hma1u0WA/yph8F2AFlThIbijryKtY5T0Hd3kq19sMGP04GCNU/ipoP DpmhN4SAz3a0ihtUv45RR3dO8oTNy26SA/4zQSMwb1sbhFw/2kW9rwoR7nBnjO0UBGPp/E L3ldq0MG/KewuHa3H8Sc1+3VJH9qgpvtKpgHc4cySrSTjgnAY3DmYCZzVrH0T1thGbbdE1 SC6aMFg0Y1iBSdGSo69phUjci/HDBfGsI6uMUyR+ysexiF11NfbjCmJRFmNNLQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1765805416; a=rsa-sha256; cv=none; b=N5Rz3z44IjwMr+fjiH+mmuQhW9KBXrAfGmPv5SyfiBM1ku/KvUh0xhGaBp1Bbhh4X48pgk CrNnDS9SBS6h7JvQUAUEV9/vDVN1bckLRaIxolzK3D/fNh3FInxy71BCrl6t375tr13Ovy cabusE74H8C53NnGjpbJgA1TmXd98Kl8cBXo5/8iURL3w1o6pCTQpedmsgVNcaKeiK3cAn iRmphQqwv+i1bdThyDdNbiG41x/qFOz1MV6XoWuCfBGUmancPA3bh54WbumhT2YGwRUl21 x3VstiFO1DeP1g3mbPbndU0T748r6gBrWJXl2u2YMi8m/XA5r/RG9MYxCzCWkQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dVLXR6Dwdz5y0 for ; Mon, 15 Dec 2025 13:30:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3199b by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 15 Dec 2025 13:30:15 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Christos Margiolis Subject: git: 6043e26b902b - stable/15 - sndctl(8): Do not free and re-open device List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 6043e26b902bacf301b0d4360a84085292608a10 Auto-Submitted: auto-generated Date: Mon, 15 Dec 2025 13:30:15 +0000 Message-Id: <69400d67.3199b.4d55d2ed@gitrepo.freebsd.org> The branch stable/15 has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=6043e26b902bacf301b0d4360a84085292608a10 commit 6043e26b902bacf301b0d4360a84085292608a10 Author: Christos Margiolis AuthorDate: 2025-12-06 14:28:08 +0000 Commit: Christos Margiolis CommitDate: 2025-12-15 13:29:22 +0000 sndctl(8): Do not free and re-open device There was a reason for this, but it does not apply anymore. Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D54031 (cherry picked from commit 643a606fa2742b94f6eca620119b7d2686ca9cd3) --- usr.sbin/sndctl/sndctl.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/usr.sbin/sndctl/sndctl.c b/usr.sbin/sndctl/sndctl.c index 6977f0ab0ebe..e6dac67e2ea7 100644 --- a/usr.sbin/sndctl/sndctl.c +++ b/usr.sbin/sndctl/sndctl.c @@ -992,17 +992,10 @@ next: argv++; } - free_dev(dp); - if (show) { - /* - * Re-read dev to reflect new state in case we changed some - * property. - */ - dp = read_dev(path); print_dev(dp); - free_dev(dp); } + free_dev(dp); return (0); }