From owner-freebsd-ports@FreeBSD.ORG Sat Dec 17 10:35:14 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 703D7106564A for ; Sat, 17 Dec 2011 10:35:14 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id F3F2D8FC0C for ; Sat, 17 Dec 2011 10:35:13 +0000 (UTC) Received: by mail-iy0-f182.google.com with SMTP id j38so2454678iad.13 for ; Sat, 17 Dec 2011 02:35:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=Dp5NAVd5jiLbu9xVnqyClDQPkM+xxqSxfXkwYChPg0A=; b=EJK5F371EHlc6oM9UDx99rnc9deQUWT4SAdWrkyVqUz9fYjHnvbdPxf7JKajdP74rJ /4Fxpj7ckQqxFOzATTUFa5U3wrbjK4U61mfkP65ngKy4M04Tschwnxi+9DrfMY7+zdo7 f1RMR+N73INI8TIHgGD0O5gVmjOrjyFZ7+J6E= Received: by 10.50.46.167 with SMTP id w7mr13958893igm.88.1324118113339; Sat, 17 Dec 2011 02:35:13 -0800 (PST) MIME-Version: 1.0 Sender: utisoft@gmail.com Received: by 10.231.199.18 with HTTP; Sat, 17 Dec 2011 02:34:42 -0800 (PST) In-Reply-To: <4EEC6D9D.1020102@yandex.ru> References: <4EEC6D9D.1020102@yandex.ru> From: Chris Rees Date: Sat, 17 Dec 2011 10:34:42 +0000 X-Google-Sender-Auth: YRnioPQ5nvDIjiKkIXdDEkvXqrI Message-ID: To: Ruslan Mahmatkhanov Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: quoted-printable Cc: Christer Edwards , "freebsd-ports@FreeBSD.org" Subject: Re: RUN_DEPENDS for python based port X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Dec 2011 10:35:14 -0000 On 17 December 2011 10:23, Ruslan Mahmatkhanov wrote: > Christer Edwards wrote on 17.12.2011 11:54: >> RUN_DEPENDS+=3D >> ${PYTHON_SITELIBDIR}/yaml/__init__.py:${PORTSDIR}/devel/py-yaml \ >> >> ${PYTHON_SITELIBDIR}/zmq/__init__.py}:${PORTSDIR}/devel/py-pyzmq \ >> >> ${PYTHON_SITELIBDIR}/Crypto/Cipher/__init__.py:${PORTSDIR}/security/py-p= ycrypto >> \ >> >> ${PYTHON_SITELIBDIR}/${PYEASYINSTALL_EGG}/jinja2/__init__.py:${PORTSDIR}= /devel/py-Jinja2 >> \ >> >> ${PYTHON_PKGNAMEPREFIX}M2Crypto>=3D0:${PORTSDIR}/security/py-m2crypto >> >> .include >> >> ----- >> >> I'm not sure if I've done the RUN_DEPENDS properly, because when I try >> to 'make' the port, it tries running the salt tool and complains about >> missing python modules. The modules are of course provided by the >> depends, but they don't get installed if they're missing. >> >> I'd really like whatever feedback the list can offer to getting this >> ported properly. >> >> Cheers, >> Christer > > Chris and Matthew already noted what the problems are. > I also suggest to use: > > ${PYTHON_PKGNAMEPREFIX}yaml>=3D0:${PORTSDIR}/devel/py-yaml > > instead of: > > ${PYTHON_SITELIBDIR}/yaml/__init__.py:${PORTSDIR}/devel/py-yaml > and > ${PYTHON_SITELIBDIR}/${PYEASYINSTALL_EGG}/jinja2/__init__.py:${PORTSDIR}/= devel/py-Jinja2 > > Right now you use three possible forms to depend on needed ports. > Better do this change because if sometime some of dependent packages > will be converted to installing via setuptools (eggs packaging) you'll > need to fix them in your port, because there will not be > `yaml/__init__.py' anymore for example. > First construct will work in both cases and unification is always good > thing to do. > > And the second note. setup.py discloses that: > 1. Port will work with python2.6/2.7 only > =9A 'Programming Language :: Python :: 2.6', > =9A 'Programming Language :: Python :: 2.7', > 2. Code licensed by Apache Software License. > =9A 'License :: OSI Approved :: Apache Software License' > > So USE_PYTHON=3Dyes should be changed with USE_PYTHON=3D =9A =9A2.6-2.7, = (otherwise > port build will fail with python3) and LICENSE=3D ASL worth to be added. Ruslan is absolutely right, we also do that with most perl dependencies; I was waiting for someone on python@ to point it out ;) Also, another mistake I've noticed: RUN_DEPENDS+=3D ${PYTHON_SITELIBDIR}/yaml/__init__.py:${PORTSDIR}/devel/py-yaml \ ${PYTHON_SITELIBDIR}/zmq/__init__.py}:${PORTSDIR}/devel/py-pyzmq \ ${PYTHON_SITELIBDIR}/Crypto/Cipher/__init__.py:${PORTSDIR}/security/py-pycr= ypto \ Are these extra newlines from wrapping? If not, you've made a BIG screwup there! The lines must be one after the other. Chris