From owner-freebsd-fs@FreeBSD.ORG Fri Apr 25 00:15:26 2008 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6E7791065685; Fri, 25 Apr 2008 00:15:26 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id 0F0AD8FC19; Fri, 25 Apr 2008 00:15:25 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from phobos.samsco.home (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.8/8.13.8) with ESMTP id m3P0FLJQ001456; Thu, 24 Apr 2008 18:15:22 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <48112299.9060007@samsco.org> Date: Thu, 24 Apr 2008 18:15:21 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.13) Gecko/20080313 SeaMonkey/1.1.9 MIME-Version: 1.0 To: Andriy Gapon References: <480E440D.2030907@icyb.net.ua> <48101269.20702@samsco.org> <48103437.6040001@icyb.net.ua> In-Reply-To: <48103437.6040001@icyb.net.ua> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=3.8 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org Cc: freebsd-fs@freebsd.org, Pav Lucistnik Subject: Re: latest udf patch X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Apr 2008 00:15:26 -0000 Andriy Gapon wrote: > on 24/04/2008 07:54 Scott Long said the following: >> Andriy Gapon wrote: >>> Maybe you will be interested in my latest UDF patch that adds very >>> simplistic support for UDF 2.XX+ (on top of all the previous >>> fixes/enhancements). >>> >>> I posted it as a followup to the following PR: >>> http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/120989 >>> >>> The patch is also available at the following URL: >>> http://www.icyb.net.ua/~avg/udf.diff.gz >>> >>> It is against RELENG_7. >>> I plan to update it at the above URL if I have anything new. >>> >> Is this ready for committing to CVS? If so I'll take care of it. > > Scott, > > thank you. > I am not sure how much testing this patch has seen. I have feedback only > from Pav. The patch definitely "works for me" and for a long time (only > extended file entry support is a recent addition). > I think there might be some style(9) violations in the patch. In couple > of places I definitely went over 80-column limit for aesthetic reasons > (and because I think 80 is too small to be required in modern times). > > I would definitely appreciate somebody reviewing the patch for style(9) > and general coding practices. > More testing (with feedback!) is always welcome for sure. > Style is a guideline, not a contract. The patch looks fine to me in that respect. Scott