From owner-freebsd-net@FreeBSD.ORG  Thu Feb 19 00:38:01 2015
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id C87FB51B
 for <freebsd-net@freebsd.org>; Thu, 19 Feb 2015 00:38:01 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id A7AC1BE8
 for <freebsd-net@freebsd.org>; Thu, 19 Feb 2015 00:38:01 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [127.0.1.5])
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id
 t1J0c1kI034608
 for <freebsd-net@freebsd.org>; Thu, 19 Feb 2015 00:38:01 GMT
 (envelope-from root@phabric-backend.isc.freebsd.org)
Received: (from root@localhost)
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1J0c1t2034607;
 Thu, 19 Feb 2015 00:38:01 GMT (envelope-from root)
Date: Thu, 19 Feb 2015 00:38:01 +0000
To: freebsd-net@freebsd.org
From: "will (Will Andrews)" <phabric-noreply@FreeBSD.org>
Subject: [Differential] [Commented On] D1881: Allow Illumos code to co-exist
 with nv(9)
Message-ID: <4ea2101a196d5ce2819139f81d7887cb@localhost.localdomain>
X-Priority: 3
Thread-Topic: D1881: Allow Illumos code to co-exist with nv(9)
X-Herald-Rules: none
X-Phabricator-To: <PHID-USER-vtlauz4uwe46gac4fu2j>
X-Phabricator-To: <PHID-USER-gsanmilqmw65clu6stb2>
X-Phabricator-Cc: <PHID-USER-dugjol6bu5tef2a5luiw>
X-Phabricator-Cc: <PHID-USER-axkijn4pfdxlezgbnt7g>
X-Phabricator-Cc: <PHID-USER-wdicbwgs4t3i2iwuuyrv>
X-Phabricator-Cc: <PHID-MLST-c3bj6mfydtlqmuethodc>
In-Reply-To: <differential-rev-PHID-DREV-pp4n6zdcmtw5j5lguv5e-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-pp4n6zdcmtw5j5lguv5e-req@FreeBSD.org>
Thread-Index: OGQwMzFkNjQ5NDRkZTRmM2I0ZmU5NDZhMGJmIFTlMGk=
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-comment>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Feb 2015 00:38:01 -0000

will added a comment.

>>! In D1881#9, @rstone wrote:
> The primary testing that I did was to ensure that a kernel with "device zfs" would still link.  However, I suppose that doesn't exclude the possibility of their being an zfs source file that is built wrong and doesn't include this header.  Is there a zfs test suite that I could run?

Not yet, unfortunately.  It's in the zfsd project branch, but needs some work so it can be pushed into head.

It'd probably be sufficient to load zfs and create pools/filesystems, and a few other basic tests.  Are the userland bits covered (and tested) with this change?  This is a <sys/nvpair.h> overload (effectively), which may be pulled into the userland zfs builds.

REVISION DETAIL
  https://reviews.freebsd.org/D1881

To: rstone, jfvogel
Cc: will, emaste, pjd, freebsd-net