From owner-freebsd-usb@FreeBSD.ORG  Sun Jul 15 16:39:02 2007
Return-Path: <owner-freebsd-usb@FreeBSD.ORG>
X-Original-To: freebsd-usb@freebsd.org
Delivered-To: freebsd-usb@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 4CE1E16A401
	for <freebsd-usb@freebsd.org>; Sun, 15 Jul 2007 16:39:02 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
Received: from swip.net (mailfe10.swip.net [212.247.155.33])
	by mx1.freebsd.org (Postfix) with ESMTP id E137C13C4BE
	for <freebsd-usb@freebsd.org>; Sun, 15 Jul 2007 16:39:01 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
X-Cloudmark-Score: 0.000000 []
Received: from [193.217.102.48] (account mc467741@c2i.net HELO [10.0.0.249])
	by mailfe10.swip.net (CommuniGate Pro SMTP 5.1.10)
	with ESMTPA id 377450916; Sun, 15 Jul 2007 18:39:00 +0200
From: Hans Petter Selasky <hselasky@c2i.net>
To: freebsd-usb@freebsd.org
Date: Sun, 15 Jul 2007 18:39:02 +0200
User-Agent: KMail/1.9.5
MIME-Version: 1.0
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200707151839.02907.hselasky@c2i.net>
Cc: Sam Leffler <sam@errno.com>
Subject: if_ural.c in FreeBSD 7-current
X-BeenThere: freebsd-usb@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: FreeBSD support for USB <freebsd-usb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-usb>
List-Post: <mailto:freebsd-usb@freebsd.org>
List-Help: <mailto:freebsd-usb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 15 Jul 2007 16:39:02 -0000

Hi,

Can someone answer me quick on this one:

In FreeBSD 7-current, I think I see some mistakes in "if_ural.c".

For example:

> #define URAL_RSSI(rssi)                                       \
>       ((rssi) > (RAL_NOISE_FLOOR + RAL_RSSI_CORR) ?   \
>        ((rssi) - RAL_NOISE_FLOOR + RAL_RSSI_CORR) : 0)


Should there be a parenthesis here ??

> #define URAL_RSSI(rssi)                                       \
>       ((rssi) > (RAL_NOISE_FLOOR + RAL_RSSI_CORR) ?   \
>        ((rssi) - (RAL_NOISE_FLOOR + RAL_RSSI_CORR)) : 0)

Also I see that the basic rate set is set multiple times:

By "set_chan" and when the RUN state is entered! This does not make sense!

--HPS