From owner-cvs-src@FreeBSD.ORG  Fri Jul 15 14:59:00 2005
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 284A016A41F;
	Fri, 15 Jul 2005 14:59:00 +0000 (GMT)
	(envelope-from bright@elvis.mu.org)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E3D8843D60;
	Fri, 15 Jul 2005 14:58:59 +0000 (GMT)
	(envelope-from bright@elvis.mu.org)
Received: by elvis.mu.org (Postfix, from userid 1192)
	id D12725CABE; Fri, 15 Jul 2005 07:58:59 -0700 (PDT)
Date: Fri, 15 Jul 2005 07:58:59 -0700
From: Alfred Perlstein <alfred@freebsd.org>
To: Paul Saab <ps@FreeBSD.org>
Message-ID: <20050715145859.GL40423@elvis.mu.org>
References: <200507142008.j6EK8RND012168@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200507142008.j6EK8RND012168@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.1i
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/nfs nfs_common.c nfs_common.h
	src/sys/nfsclient nfs_socket.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Jul 2005 14:59:00 -0000

* Paul Saab <ps@FreeBSD.org> [050714 13:08] wrote:
> ps          2005-07-14 20:08:27 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/nfs              nfs_common.c nfs_common.h 
>     sys/nfsclient        nfs_socket.c 
>   Log:
>   Fixes for NFS crashes on architectures that require strict alignment.
>   - Fix nfsm_disct() so that after pulling up data, the remaining data
>     is aligned if necessary.

Ugh, why not do it beforehand to reduce the copy?  This looks like
you'll move all this data into a single mbuf, then possibly shift
all the contents, can't you shift the initial mbuf first, THEN
do the pullup?

>   - Fix nfs_clnt_tcp_soupcall() to bcopy() the rpc length out of the
>     mbuf (instead of casting m_data to a uint32).

Also, is bcopy(9) light enough to be used for this purpose or do
we have something to do unaligned reads?

>   
>   Submitted by:   Pyun YongHyeon
>   Reviewed by:    Mohan Srinivasan
>   
>   Revision  Changes    Path
>   1.118     +12 -3     src/sys/nfs/nfs_common.c
>   1.38      +6 -0      src/sys/nfs/nfs_common.h
>   1.126     +2 -1      src/sys/nfsclient/nfs_socket.c

-- 
- Alfred Perlstein
- email: bright@mu.org cell: 408-480-4684