From owner-cvs-all Tue Oct 24 21:52: 6 2000 Delivered-To: cvs-all@freebsd.org Received: from pike.osd.bsdi.com (pike.osd.bsdi.com [204.216.28.222]) by hub.freebsd.org (Postfix) with ESMTP id 9212637B479; Tue, 24 Oct 2000 21:52:03 -0700 (PDT) Received: from laptop.baldwin.cx (ether.osd.bsdi.com [204.216.28.196]) by pike.osd.bsdi.com (8.11.0/8.9.3) with ESMTP id e9P4pcf87626; Tue, 24 Oct 2000 21:51:38 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: Date: Tue, 24 Oct 2000 21:52:18 -0700 (PDT) From: John Baldwin To: Matthew Jacob Subject: Re: Making work for others (was: cvs commit: src/sys/sys mutex.h Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Poul-Henning Kamp , Greg Lehey Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 25-Oct-00 Matthew Jacob wrote: > >> > Modified files: >> > sys/sys mutex.h >> > Log: >> > Generate LOTS of warnings to remind the SMPng crew to fix the curproc >> > UP/SMP issue. >> >> Is this necessary? Making work for other people isn't the way to go. >> If you find the problem objectionable, do what others do and fix it. > > Naw, I think he did the right thing. The warnings aren't that bad. I prefer the warnings to attempting to fix the problem as the fix would have to be backed out later, whereas the warnings will go away on their own once it is properly fixed with PCPU_GET(). -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message