Date: Tue, 3 Nov 2015 22:23:09 +0000 (UTC) From: "Andrey V. Elsukov" <ae@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r290345 - head/sys/netpfil/ipfw Message-ID: <201511032223.tA3MN97n002060@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: ae Date: Tue Nov 3 22:23:09 2015 New Revision: 290345 URL: https://svnweb.freebsd.org/changeset/base/290345 Log: Remove now obsolete KASSERT. Actually, object classify callbacks can skip some opcodes, that could be rewritten. We will deteremine real numbed of rewritten opcodes a bit later in this function. Reported by: David H. Wolfskill <david at catwhisker dot org> Modified: head/sys/netpfil/ipfw/ip_fw_table.c Modified: head/sys/netpfil/ipfw/ip_fw_table.c ============================================================================== --- head/sys/netpfil/ipfw/ip_fw_table.c Tue Nov 3 22:06:24 2015 (r290344) +++ head/sys/netpfil/ipfw/ip_fw_table.c Tue Nov 3 22:23:09 2015 (r290345) @@ -3388,14 +3388,8 @@ ref_rule_objects(struct ip_fw_chain *ch, IPFW_UH_WUNLOCK(ch); return (error); } - IPFW_UH_WUNLOCK(ch); - found = pidx - oib; - KASSERT(found == ci->object_opcodes, - ("refcount inconsistency: found: %d total: %d", - found, ci->object_opcodes)); - /* Perform auto-creation for non-existing objects */ if (numnew != 0) error = create_objects_compat(ch, rule->cmd, oib, pidx, ti);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201511032223.tA3MN97n002060>