From owner-svn-src-all@FreeBSD.ORG  Wed Sep 26 06:58:26 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 324CC106566B;
	Wed, 26 Sep 2012 06:58:26 +0000 (UTC)
	(envelope-from glebius@FreeBSD.org)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.64.117])
	by mx1.freebsd.org (Postfix) with ESMTP id A22398FC18;
	Wed, 26 Sep 2012 06:58:25 +0000 (UTC)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
	by cell.glebius.int.ru (8.14.5/8.14.5) with ESMTP id q8Q6wOJX085684;
	Wed, 26 Sep 2012 10:58:24 +0400 (MSK)
	(envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
	by cell.glebius.int.ru (8.14.5/8.14.5/Submit) id q8Q6wOeh085683;
	Wed, 26 Sep 2012 10:58:24 +0400 (MSK)
	(envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
	glebius@FreeBSD.org using -f
Date: Wed, 26 Sep 2012 10:58:24 +0400
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Ed Maste <emaste@FreeBSD.org>
Message-ID: <20120926065824.GA50433@FreeBSD.org>
References: <201209252210.q8PMAEx5003950@svn.freebsd.org>
	<20120926065615.GZ50433@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <20120926065615.GZ50433@FreeBSD.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: svn commit: r240938 - head/sys/net
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Sep 2012 06:58:26 -0000

On Wed, Sep 26, 2012 at 10:56:15AM +0400, Gleb Smirnoff wrote:
T>   Ed,
T> 
T> On Tue, Sep 25, 2012 at 10:10:14PM +0000, Ed Maste wrote:
T> E> Author: emaste
T> E> Date: Tue Sep 25 22:10:14 2012
T> E> New Revision: 240938
T> E> URL: http://svn.freebsd.org/changeset/base/240938
T> E> 
T> E> Log:
T> E>   Avoid INVARIANTS panic destroying an in-use tap(4)
T> E>   
T> E>   The requirement (implied by the KASSERT in tap_destroy) that the tap is
T> E>   closed isn't valid; destroy_dev will block in devdrn while other threads
T> E>   are in d_* functions.
T> E>   
T> E>   Note: if_tun had the same issue, addressed in SVN revisions r186391,
T> E>   r186483 and r186497.  The use of the condvar there appears to be
T> E>   redundant with the functionality provided by destroy_dev.
T> 
T> So why did you add condvar to the softc? See it in diff below.

Noticed later commit, sorry for noise.

-- 
Totus tuus, Glebius.