From owner-svn-src-head@FreeBSD.ORG Fri Dec 28 02:34:07 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C0BC03EE; Fri, 28 Dec 2012 02:34:07 +0000 (UTC) (envelope-from gonzo@id.bluezbox.com) Received: from id.bluezbox.com (id.bluezbox.com [88.198.91.248]) by mx1.freebsd.org (Postfix) with ESMTP id 2C5438FC0A; Fri, 28 Dec 2012 02:34:07 +0000 (UTC) Received: from [88.198.91.248] (helo=[IPv6:::1]) by id.bluezbox.com with esmtpsa (TLSv1:CAMELLIA256-SHA:256) (Exim 4.77 (FreeBSD)) (envelope-from ) id 1ToPls-000906-6A; Thu, 27 Dec 2012 18:34:06 -0800 Message-ID: <50DD0518.5000202@freebsd.org> Date: Thu, 27 Dec 2012 18:34:00 -0800 From: Oleksandr Tymoshenko User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Konstantin Belousov Subject: Re: svn commit: r244445 - in head/sys: kern sys tools References: <201212192010.qBJKA0lb075959@svn.freebsd.org> <50DCFDEE.8080404@freebsd.org> <20121228021425.GO82219@kib.kiev.ua> <50DD031E.409@freebsd.org> <20121228022923.GP82219@kib.kiev.ua> In-Reply-To: <20121228022923.GP82219@kib.kiev.ua> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: gonzo@id.bluezbox.com X-Spam-Level: -- X-Spam-Report: Spam detection software, running on the system "id.bluezbox.com", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see The administrator of that system for details. Content preview: On 12/27/2012 6:29 PM, Konstantin Belousov wrote: > On Thu, Dec 27, 2012 at 06:25:34PM -0800, Oleksandr Tymoshenko wrote: >> On 12/27/2012 6:14 PM, Konstantin Belousov wrote: >>> On Thu, Dec 27, 2012 at 06:03:26PM -0800, Oleksandr Tymoshenko wrote: >>>> On 12/19/2012 12:10 PM, Jeff Roberson wrote: >>>>> Author: jeff >>>>> Date: Wed Dec 19 20:10:00 2012 >>>>> New Revision: 244445 >>>>> URL: http://svnweb.freebsd.org/changeset/base/244445 >>>>> >>>>> Log: >>>>> - Add new machine parsable KTR macros for timing events. >>>>> - Use this new format to automatically handle syscalls and VOPs. This >>>>> changes the earlier format but is still human readable. >>>>> >>>>> Sponsored by: EMC / Isilon Storage Division >>>> Jeff, >>>> >>>> please fix tinderbox breakage caused by this commit >>>> >>>> ARM kernel build with KTR option is still broken as of today: >>>> >>>> http://tinderbox.freebsd.org/tinderbox-head-ss-build-HEAD-arm-arm.brief >>>> >>>> In file included from /src/sys/arm/arm/trap.c:900: >>>> /src/sys/arm/arm/../../kern/subr_syscall.c: In function 'syscallenter': >>>> /src/sys/arm/arm/../../kern/subr_syscall.c:80: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] >>>> /src/sys/arm/arm/../../kern/subr_syscall.c:154: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] >>>> *** [trap.o] Error code 1 >>>> >>>> >>>> Thank you >>> I am running a fix through the make universe right now. >>> If you can compile just ARM and confirm that gcc is silenced by this, >>> I will commit it before make universe finishes. >>> >>> diff --git a/sys/kern/subr_syscall.c b/sys/kern/subr_syscall.c >>> index 3dcfcf5..349b410 100644 >>> --- a/sys/kern/subr_syscall.c >>> +++ b/sys/kern/subr_syscall.c >>> @@ -77,7 +77,7 @@ syscallenter(struct thread *td, struct syscall_args *sa) >>> if (KTRPOINT(td, KTR_SYSCALL)) >>> ktrsyscall(sa->code, sa->narg, sa->args); >>> #endif >>> - KTR_START4(KTR_SYSC, "syscall", syscallname(p, sa->code), >>> + KTR_START4(KTR_SYSC, "syscall", [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: svn-src-head@freebsd.org, Jeff Roberson , src-committers@freebsd.org, svn-src-all@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Dec 2012 02:34:07 -0000 On 12/27/2012 6:29 PM, Konstantin Belousov wrote: > On Thu, Dec 27, 2012 at 06:25:34PM -0800, Oleksandr Tymoshenko wrote: >> On 12/27/2012 6:14 PM, Konstantin Belousov wrote: >>> On Thu, Dec 27, 2012 at 06:03:26PM -0800, Oleksandr Tymoshenko wrote: >>>> On 12/19/2012 12:10 PM, Jeff Roberson wrote: >>>>> Author: jeff >>>>> Date: Wed Dec 19 20:10:00 2012 >>>>> New Revision: 244445 >>>>> URL: http://svnweb.freebsd.org/changeset/base/244445 >>>>> >>>>> Log: >>>>> - Add new machine parsable KTR macros for timing events. >>>>> - Use this new format to automatically handle syscalls and VOPs. This >>>>> changes the earlier format but is still human readable. >>>>> >>>>> Sponsored by: EMC / Isilon Storage Division >>>> Jeff, >>>> >>>> please fix tinderbox breakage caused by this commit >>>> >>>> ARM kernel build with KTR option is still broken as of today: >>>> >>>> http://tinderbox.freebsd.org/tinderbox-head-ss-build-HEAD-arm-arm.brief >>>> >>>> In file included from /src/sys/arm/arm/trap.c:900: >>>> /src/sys/arm/arm/../../kern/subr_syscall.c: In function 'syscallenter': >>>> /src/sys/arm/arm/../../kern/subr_syscall.c:80: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] >>>> /src/sys/arm/arm/../../kern/subr_syscall.c:154: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] >>>> *** [trap.o] Error code 1 >>>> >>>> >>>> Thank you >>> I am running a fix through the make universe right now. >>> If you can compile just ARM and confirm that gcc is silenced by this, >>> I will commit it before make universe finishes. >>> >>> diff --git a/sys/kern/subr_syscall.c b/sys/kern/subr_syscall.c >>> index 3dcfcf5..349b410 100644 >>> --- a/sys/kern/subr_syscall.c >>> +++ b/sys/kern/subr_syscall.c >>> @@ -77,7 +77,7 @@ syscallenter(struct thread *td, struct syscall_args *sa) >>> if (KTRPOINT(td, KTR_SYSCALL)) >>> ktrsyscall(sa->code, sa->narg, sa->args); >>> #endif >>> - KTR_START4(KTR_SYSC, "syscall", syscallname(p, sa->code), >>> + KTR_START4(KTR_SYSC, "syscall", (uintptr_t)syscallname(p, sa->code), >>> td, "pid:%d", td->td_proc->p_pid, "arg0:%p", sa->args[0], >>> "arg1:%p", sa->args[1], "arg2:%p", sa->args[2]); >>> >>> @@ -151,7 +151,7 @@ syscallenter(struct thread *td, struct syscall_args *sa) >>> syscall_thread_exit(td, sa->callp); >>> } >>> retval: >>> - KTR_STOP4(KTR_SYSC, "syscall", syscallname(p, sa->code), >>> + KTR_STOP4(KTR_SYSC, "syscall", (uintptr_t)syscallname(p, sa->code), >>> td, "pid:%d", td->td_proc->p_pid, "error:%d", error, >>> "retval0:%#lx", td->td_retval[0], "retval1:%#lx", >>> td->td_retval[1]); >> Didn't help. It's td, not sysclalname result that gcc complains about: >> >> http://people.freebsd.org/~gonzo/patches/ktr-syscall-fix.diff > Ok, commit ? Assuming it compiles. Let me check it with "make universe"